Skip to content

2.6.2 Hotfix - Update RestSharp and Greg#12804

Merged
QilongTang merged 6 commits intoRC2.6.2_masterfrom
UpdateRestSharp
Apr 18, 2022
Merged

2.6.2 Hotfix - Update RestSharp and Greg#12804
QilongTang merged 6 commits intoRC2.6.2_masterfrom
UpdateRestSharp

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Apr 14, 2022 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Hotfix 2.6.2 - update Greg and RestSharp

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Hotfix - update Greg and RestSharp

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang
Copy link
Contributor Author

QilongTang commented Apr 14, 2022

Currently blocked with one build error that Greg.Requests.Hosts public class is missing from target dll. This is actually breaking API backward compatibility. Looking for more insights from Turbo Team. FYI: @pinzart @jasonstratton

@QilongTang QilongTang changed the title Update RestSharp and Greg 2.6.2 Hotfix - Update RestSharp and Greg Apr 14, 2022
@QilongTang QilongTang added this to the 2.6.2 milestone Apr 14, 2022
@QilongTang
Copy link
Contributor Author

QilongTang commented Apr 15, 2022 •
edited
Loading

This is now ready for review, once merged, this can be cherry-picked to 2.3.2. Thanks @pinzart @mjkkirschner for the Greg update again. I have verified locally Dynamo 2.6.2 can be built and launched normally with pm working

@QilongTang QilongTang marked this pull request as ready for review April 15, 2022 19:21
@QilongTang
Copy link
Contributor Author

QilongTang commented Apr 18, 2022 •
edited
Loading

Thanks @pinzart, this branch now builds correctly, except for ASM grabbing which is not part of this repo
image

Thanks @reddyashish for the review, merging

@QilongTang QilongTang merged commit d82f160 into RC2.6.2_master Apr 18, 2022
@QilongTang QilongTang deleted the UpdateRestSharp branch April 18, 2022 12:54
QilongTang added a commit that referenced this pull request Apr 18, 2022
@QilongTang
2.6.2 Hotfix - Update RestSharp and Greg (#12804)
6f8e0f4 
* Update RestSharp and Greg

* Update

* versions

* version updates for net452

* Update Greg version

* Update Greg version
@QilongTang QilongTang mentioned this pull request Apr 18, 2022
Merged
8 tasks
QilongTang added a commit that referenced this pull request Apr 19, 2022
@QilongTang
Hotfix 2.3.2 Cherry-Pick #12804 (#12808)
ecdd570 
* 2.6.2 Hotfix - Update RestSharp and Greg (#12804)

* Update RestSharp and Greg

* Update

* versions

* version updates for net452

* Update Greg version

* Update Greg version

* Update version

* version number

* revert version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reddyashish reddyashish reddyashish approved these changes

@pinzart pinzart Awaiting requested review from pinzart

@mjkkirschner mjkkirschner Awaiting requested review from mjkkirschner

@zeusongit zeusongit Awaiting requested review from zeusongit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.6.2

Development

Successfully merging this pull request may close these issues.

2 participants

@QilongTang @reddyashish