Visual indication of function state#12758
Merged
QilongTang merged 5 commits intoDynamoDS:masterfrom Apr 4, 2022
Merged
Conversation
Contributor
|
@filipeotero - A couple of things:
|
QilongTang
reviewed
Mar 31, 2022
QilongTang
reviewed
Mar 31, 2022
QilongTang
reviewed
Mar 31, 2022
QilongTang
reviewed
Mar 31, 2022
| VerticalAlignment="Center" | ||
| Fill="{Binding PortValueMarkerColor, UpdateSourceTrigger=PropertyChanged}" | ||
| IsHitTestVisible="False" | ||
| SnapsToDevicePixels="True" /> |
Contributor
Author
Contributor
There was a problem hiding this comment.
Then maybe update the comment to reflect that, I got confused because it says on the left of the port
Contributor
There was a problem hiding this comment.
Once the comment updated here, LGTM
Contributor
Author
There was a problem hiding this comment.
Comment updated. Thanks!
|
Contributor
Author
|
@Amoursol @Jingyi-Wen |
Looks great to me! |
Set the colors in xaml file; Minor fixes;
Contributor
Looks awesome @filipeotero! |
QilongTang
approved these changes
Apr 4, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
This PR implements visual improvements at node ports to indicate if a Function Node is in an active/inactive state.
A new rectangle was added in the output port to represent the active/inactive state.
Considering that Function State is represented by the boolean
IsPartiallyApplied, here are how some states are working in the implementation of this PR.State 1 - Function state but not passing a function (Output port is not connected to another node)
State 2 - Function passing (Output port is connected to another node and passing a function)
State 3 - All input ports are connected, so are not considered at function state anymore (Standard connected input colors)
State 4 - The input ports have default values, so it's not considered at function state (Standard connected input colors)
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @mjkkirschner
FYIs
@jesusalvino @RobertGlobant20