Do not include elements in collapsed group to box selection#12751
Merged
QilongTang merged 1 commit intomasterfrom Mar 30, 2022
Merged
Do not include elements in collapsed group to box selection#12751QilongTang merged 1 commit intomasterfrom
QilongTang merged 1 commit intomasterfrom
Conversation
reddyashish
approved these changes
Mar 30, 2022
zeusongit
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Per https://jira.autodesk.com/browse/DYN-4674 Do not include elements in collapsed groups to box selection. Due to the nature of this issue, hard to unit test this, need test complete case.
Below is a gif showing the corrected behavior after the fix. Before the fix, the

Child 1group will be selected which is wrong.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Do not include elements in collapsed group to box selection
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of