Dummy Node Remove Color Overlays#12743
Merged
sm6srw merged 2 commits intoDynamoDS:masterfrom Mar 30, 2022
Merged
Conversation
Removed some of the styling elements fighting visually with the Dummy Node. This node is used for Unresolved or Deprecated nodes and does not require any visual candy to function.
Contributor
|
FYI @QilongTang |
Contributor
|
@dnenov - Can you just double check that the "Dummy Node" still correctly shows the Frozen state as per the image below when not zoomed out?
|
sm6srw
reviewed
Mar 29, 2022
src/Libraries/CoreNodeModelsWpf/NodeViewCustomizations/DummyNode.cs
Outdated
Show resolved
Hide resolved
- reverted change where frozen overlay in zoomed-in state will be removed
sm6srw
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A small change to the Dummy Node. The Dummy Node is used for Unresolved or Deprecated Nodes. It will effectively replace any node and has no functionality but to visually represent this state. As such, it does not require the visual candy used in normal nodes, and all the extra glyphs showing Frozen, Hidden, Warning, Error, or Info states were removed.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Visual update to the Dummy Node.
Reviewers
@sm6srw
FYIs
@Amoursol