Skip to content

RestSharp update as Hotfix 2.12.1#12739

Merged
QilongTang merged 3 commits intoRC2.12.1_masterfrom
RestSharpUpdate
Mar 25, 2022
Merged

RestSharp update as Hotfix 2.12.1#12739
QilongTang merged 3 commits intoRC2.12.1_masterfrom
RestSharpUpdate

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Mar 25, 2022 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

RestSharp update as Hotfix 2.12.1. Cherry-picking #12165

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

RestSharp update as Hotfix 2.12.1

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

mjkkirschner and others added 3 commits March 25, 2022 11:08
@mjkkirschner @QilongTang
Update Greg.dll and Restsharp (#12165)
03b11f0 
* add null checking to method

* remove greg and rest sharp deps from libraryviewextension

* remove viewextenlibTests ref on restsharp

* updated ref to greg and restsharp - this builds but targets net452 version of restsharp

* update to latest greg version

* revert shared info version

* fix bad merge conflict and bad hint path

* fix

Co-authored-by: michael kirschner <[email protected]>
@QilongTang
Switch to 2019 VS build machine
78b59da
@QilongTang
Update Build Number
36111af
@QilongTang QilongTang added this to the 2.12.1 milestone Mar 25, 2022
@QilongTang
Copy link
Contributor Author

QilongTang commented Mar 25, 2022

@mjkkirschner @pinzart90 @zeusongit @reddyashish I am merging to try building it and test

@QilongTang QilongTang merged commit 03aa73d into RC2.12.1_master Mar 25, 2022
@QilongTang QilongTang deleted the RestSharpUpdate branch March 25, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzart90 pinzart90 pinzart90 approved these changes

@mjkkirschner mjkkirschner Awaiting requested review from mjkkirschner

@reddyashish reddyashish Awaiting requested review from reddyashish

@zeusongit zeusongit Awaiting requested review from zeusongit

@pinzart pinzart Awaiting requested review from pinzart

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.12.1

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongTang @pinzart90 @mjkkirschner