DYN-4686 several changes in the group style context menu.#12728
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom Mar 23, 2022
RobertGlobant20:DYN-4686-SeveralFixes-GroupStyleContextMenu
Merged
DYN-4686 several changes in the group style context menu.#12728QilongTang merged 1 commit intoDynamoDS:masterfrom RobertGlobant20:DYN-4686-SeveralFixes-GroupStyleContextMenu
QilongTang merged 1 commit intoDynamoDS:masterfrom
RobertGlobant20:DYN-4686-SeveralFixes-GroupStyleContextMenu
Conversation
- Removed the IsChecked property so is not serialized into the dyn file. - Removed the CurrentGroupStyleSelected property due that is was used for the checkmark functionality. - All the functionality for checking and unchecking groupstyle menuitems was removed. - Removed the checkmark label that was appearing next to the group style. - The color contextmenu was moved to be a submenuitem.
Contributor
Author
|
This is a GIF of the fix. |
reddyashish
approved these changes
Mar 23, 2022
Contributor
|
for I assume you mean preferences setting xml not dyn? |
QilongTang
approved these changes
Mar 23, 2022
Contributor
Author
@QilongTang yes, you are right I was talking about the settings xml file in the GroupStyles section. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Several changes for the AnnotationView context menu for showing group styles and colors.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Several changes for the AnnotationView context menu for showing group styles and colors.
Reviewers
@reddyashish
FYIs
@QilongTang