Added shift + click to nodes and notes to remove from current group#12571
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Feb 13, 2022
johnpierson:featureAdd_shiftClickForRemoveFromGroup_john
Merged
Added shift + click to nodes and notes to remove from current group#12571QilongTang merged 2 commits intoDynamoDS:masterfrom johnpierson:featureAdd_shiftClickForRemoveFromGroup_john
QilongTang merged 2 commits intoDynamoDS:masterfrom
johnpierson:featureAdd_shiftClickForRemoveFromGroup_john
Conversation
Member
|
just my two cents -
|
Member
Author
|
Thanks for taking a look! Nested groups behave how I would expect/want them to. If the node or note is the last in a group it drops the whole group 2022-01-21.14-37-49.mp4. |
QilongTang
approved these changes
Feb 11, 2022
Contributor
|
Tested and updated some comments. I found it hard to connect this with a new unit test especially the real-time shift key check. Once the PR check passed, will merge as it is. |
Member
Author
|
😱 oh my gosh. My first real contribution to dynamo's code. |
Contributor
The first of many hopefully dude 💪 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds shift-click remove from group features to nodes and notes.
2022-01-21.14-22-43.mp4
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Drag adding nodes to groups is awesome. This adds the ability to remove nodes and notes from groups with shift+left click.
Reviewers
@QilongTang
FYIs
@Amoursol