2.13.1 fix ui hang when concurrent run and save.#12570
Merged
mjkkirschner merged 3 commits intoDynamoDS:RC2.13.1_masterfrom Jan 21, 2022
Merged
2.13.1 fix ui hang when concurrent run and save.#12570mjkkirschner merged 3 commits intoDynamoDS:RC2.13.1_masterfrom
mjkkirschner merged 3 commits intoDynamoDS:RC2.13.1_masterfrom
Conversation
…empt 1 (DynamoDS#12564) * attempt 1, this works but seems odd. * switch executingTask for RunEnabled * put external files back in wsm * int to private * remove usings * revert change * revert change Co-authored-by: michael kirschner <[email protected]>
Member
Author
|
tests are running. |
QilongTang
approved these changes
Jan 21, 2022
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM. Do you also have some auto-formatting add-in installed?
Member
Author
|
I formatted with visual studio at some point 😢 |
Contributor
Oh no worries. I scanned through the whole PR and found it's purely about removing the heartbeat which is good |
pinzart90
approved these changes
Jan 21, 2022
Member
Author
|
there is another change @QilongTang - |
Member
Author
|
tests passed, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry pick:
#12564