fix crash when removing node from group that contains note.#12551
Merged
mjkkirschner merged 1 commit intoDynamoDS:masterfrom Jan 19, 2022
Merged
fix crash when removing node from group that contains note.#12551mjkkirschner merged 1 commit intoDynamoDS:masterfrom
mjkkirschner merged 1 commit intoDynamoDS:masterfrom
Conversation
QilongTang
approved these changes
Jan 18, 2022
Contributor
|
LGTM.. And you are quick :) |
Member
Author
|
tests are not kicking off currently, so running manually: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/5239/ |
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Jan 19, 2022
add test Co-authored-by: michael kirschner <[email protected]>
Merged
mjkkirschner
added a commit
that referenced
this pull request
Jan 19, 2022
add test Co-authored-by: michael kirschner <[email protected]> Co-authored-by: michael kirschner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-4505
add null check to linq query
add test
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
fix crash when removing node from group that contains note.