Connector context menu lazy load by M-JULIANI · Pull Request #12091 · DynamoDS/Dynamo

M-JULIANI · 2021-09-29T17:15:50Z

@saintentropy probably best to merge Wire connector UI modifications #12072 before this. We can handle any conflicts in this PR. Also we probably want to profile them separately to understand where we are/aren't getting performance improvements? I've never done that before but will speak to Ollie about getting some basic numbers done.

Description

This PR:

Separates out the connector ContextMenu from Connectors.xaml into a ConnectorContextMenuViewModel and associated view that gets created when right clicked, and set to null when mouse leaves or when an action is complete.
Styles the ContextMenu properly.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

Reviewers

@saintentropy
@QilongTang

FYIs

@SHKnudsen
@Amoursol

…kups.

…#12069) * Add visiblity trigger to empty tooltip strings * PR comment * Pr comments Co-authored-by: Craig Long <[email protected]>

* add pins to groups * Update ConnectorPinView.xaml.cs

* Polyline + thick outline removed. * Removed 'ConnectorType` menu from view->connectors. * Updated connector styles. * New resources added/old ones removed. Minor UI updates to reflect mockups.

* make sure nodes gets added to parent group * remove commented code Co-authored-by: Aaron (Qilong) <[email protected]>

M-JULIANI · 2021-09-30T10:15:43Z

@QilongTang one sec fixing a few things..

…-JULIANI/Dynamo into Connector-ContextMenu-LazyLoad

M-JULIANI · 2021-09-30T10:58:55Z

OK fixes made @QilongTang.

M-JULIANI · 2021-10-01T08:10:01Z

@QilongTang let me know if the Self-Serve is something on my end.

QilongTang · 2021-10-01T08:57:00Z

@QilongTang let me know if the Self-Serve is something on my end.

~~Nope, those are tests failures from the test Oliver added for package manager which got disabled.~~

src/DynamoCoreWpf/Properties/Resources.en-US.resx

src/DynamoCoreWpf/UI/Themes/Modern/DynamoModern.xaml

src/DynamoCoreWpf/Views/Core/ConnectorContextMenuView.xaml.cs

src/DynamoCoreWpf/ViewModels/Preview/ConnectorContextMenuViewModel.cs

QilongTang

Some comments, then LGTM

…nds.

M-JULIANI · 2021-10-04T07:55:43Z

@QilongTang unit tests added :)

QilongTang · 2021-10-04T12:27:11Z

The regression list shown are not related to this PR. Merging.

DynamoCoreWpfTests.PackageManagerUITests.CannotCreateDuplicatePackageSearchDialogs
DynamoCoreWpfTests.PackageManagerUITests.CanOpenPackageSearchDialogAndWindowIsOwned
DynamoCoreWpfTests.PackageManagerUITests.PackageSearchDialogClosesWithDynamo

QilongTang · 2021-10-04T16:07:42Z

I apologize, the three regressions are related to this PR, the fix is proposed in #12106

M-JULIANI and others added 30 commits September 27, 2021 14:50

Polyline + thick outline removed.

fb342f0

Removed 'ConnectorType` menu from view->connectors.

095af46

Updated connector styles.

0c815b7

New resources added/old ones removed. Minor UI updates to reflect moc…

389947b

…kups.

Merge branch 'master' into WireConnector-UI-Modifications

41e0b9e

First commit.

85a5bba

Cleanup. On-the-fly ContextMenu working.

2fcf08b

Applying ContextMenu styling.

81b3c95

Added (stole) ContextMenu styling.

648da3e

Added resource strings to ContextMenu control.

1d855eb

Update AssemblySharedInfo.cs

4f46d9d

Unused ref removal.

7fbf5e8

Cleanup.

e738d94

Merge branch 'master' into Connector-ContextMenu-LazyLoad

55e752f

Fixes.

41ac6a4

First commit.

4f18a29

Cleanup. On-the-fly ContextMenu working.

1e35f5d

Applying ContextMenu styling.

2251ef1

Added (stole) ContextMenu styling.

c74cd1b

Added resource strings to ContextMenu control.

4111fba

Update AssemblySharedInfo.cs

ffc4e5b

Cleanup.

fa913c9

Adding 10 to margin (DynamoDS#12076)

e39e683

Update AnnotationModel.cs (DynamoDS#12086)

385cdb8

Crash Fix. Add visibility trigger to empty tooltip strings. (DynamoDS…

909027b

…#12069) * Add visiblity trigger to empty tooltip strings * PR comment * Pr comments Co-authored-by: Craig Long <[email protected]>

DYN-3992: Upgrade LibG (DynamoDS#12060)

ae1c5c0

mark test as failure temporarily to fix build issues (DynamoDS#12090)

555fe6e

add pins to groups (DynamoDS#12070)

fb9edf2

* add pins to groups * Update ConnectorPinView.xaml.cs

Remove outdated logic (DynamoDS#12081)

11a1dff

Wire connector UI modifications (DynamoDS#12072)

662fad9

* Polyline + thick outline removed. * Removed 'ConnectorType` menu from view->connectors. * Updated connector styles. * New resources added/old ones removed. Minor UI updates to reflect mockups.

SHKnudsen and others added 2 commits September 30, 2021 11:03

[DYN-4105] Make sure nodes gets added to parent group (DynamoDS#12084)

dd00cfb

* make sure nodes gets added to parent group * remove commented code Co-authored-by: Aaron (Qilong) <[email protected]>

Updates resource strings from Remove to Delete (DynamoDS#12088)

de4f580

M-JULIANI added 2 commits September 30, 2021 11:55

Improved ContextMenu behaviour.

9fc77e5

Merge branch 'Connector-ContextMenu-LazyLoad' of https://github.com/M…

ce80adc

…-JULIANI/Dynamo into Connector-ContextMenu-LazyLoad