Merged
Conversation
SHKnudsen
force-pushed
the
And-connector-pins-to-groups
branch
from
338c79b to
8f98c95
Compare
QilongTang
reviewed
Sep 29, 2021
|
|
||
| public ConnectorPinView() | ||
| { | ||
| Resources.MergedDictionaries.Add(SharedDictionaryManager.DynamoConvertersDictionary); |
Contributor
There was a problem hiding this comment.
Hi @SHKnudsen Can you remind me what is this for? I thought at some point we conclude this does not work? Or maybe I misunderstood
Contributor
Author
There was a problem hiding this comment.
Need to load the converters to be able to use InverseBoolToVisibilityCollapsedConverter so that we can collapse the pins
https://github.com/DynamoDS/Dynamo/pull/12070/files#diff-bb986eed1172de44f4bd46182f227792c03db1a77bbb4d76a206b7f8c0c126e0R15
Contributor
There was a problem hiding this comment.
Can you put this as a comment? Once that is done, this is good to go, thanks for doing it
QilongTang
reviewed
Sep 29, 2021
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
One comment then LGTM
QilongTang
approved these changes
Sep 30, 2021
M-JULIANI
pushed a commit
to M-JULIANI/Dynamo
that referenced
this pull request
Sep 30, 2021
* add pins to groups * Update ConnectorPinView.xaml.cs
QilongTang
added a commit
that referenced
this pull request
Oct 4, 2021
* Polyline + thick outline removed. * Removed 'ConnectorType` menu from view->connectors. * Updated connector styles. * New resources added/old ones removed. Minor UI updates to reflect mockups. * First commit. * Cleanup. On-the-fly ContextMenu working. * Applying ContextMenu styling. * Added (stole) ContextMenu styling. * Added resource strings to ContextMenu control. * Update AssemblySharedInfo.cs * Unused ref removal. * Cleanup. * Fixes. * First commit. * Cleanup. On-the-fly ContextMenu working. * Applying ContextMenu styling. * Added (stole) ContextMenu styling. * Added resource strings to ContextMenu control. * Update AssemblySharedInfo.cs * Cleanup. * Adding 10 to margin (#12076) * Update AnnotationModel.cs (#12086) * Crash Fix. Add visibility trigger to empty tooltip strings. (#12069) * Add visiblity trigger to empty tooltip strings * PR comment * Pr comments Co-authored-by: Craig Long <[email protected]> * DYN-3992: Upgrade LibG (#12060) * mark test as failure temporarily to fix build issues (#12090) * add pins to groups (#12070) * add pins to groups * Update ConnectorPinView.xaml.cs * Remove outdated logic (#12081) * Wire connector UI modifications (#12072) * Polyline + thick outline removed. * Removed 'ConnectorType` menu from view->connectors. * Updated connector styles. * New resources added/old ones removed. Minor UI updates to reflect mockups. * [DYN-4105] Make sure nodes gets added to parent group (#12084) * make sure nodes gets added to parent group * remove commented code Co-authored-by: Aaron (Qilong) <[email protected]> * Updates resource strings from Remove to Delete (#12088) * Improved ContextMenu behaviour. * PR fix. * Removed unnecessary refs. * Added unit tests for ConnectorContextMenu construction/disposal/commands. Co-authored-by: filipeotero <[email protected]> Co-authored-by: Sylvester Knudsen <[email protected]> Co-authored-by: Craig Long <[email protected]> Co-authored-by: Craig Long <[email protected]> Co-authored-by: Jorgen Dahl <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Ollie Green <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR makes sure that Connector Pins are added to groups.
Only pins where both the Connector Start and End owner belong to the group get added.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs