Mark graph modified when group IsExpanded state is changed#12066
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Sep 28, 2021
Merged
Conversation
SHKnudsen
changed the title
QilongTang
approved these changes
Sep 27, 2021
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Would you add a unit test for it?
Contributor
Author
|
@QilongTang added a test for this |
Contributor
|
@SHKnudsen Perfect. Waiting for unit test pipeline to pass before merging. |
Contributor
|
The regression failure test is due to other changes by our team, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR marks the graph as modified when the
IsExpandedstate is changed.Related to DYN-3890
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs