Merged
Conversation
* initial commit * wip * clean up * remove leftovers * UndoRedo behaviour + grouped groups cut out + general fixes * update images * fix CopyPaste + few minor bugs * minor clean ups * Group improvements unit tests (#29) * WIP * view model tests * initial commit * wip * clean up * remove leftovers * UndoRedo behaviour + grouped groups cut out + general fixes * update images * fix CopyPaste + few minor bugs * minor clean ups * Update SerializationTests.cs * Update SerializationTests.cs * comment updates * comment updates * fix GetOutputPorts errors * fix serialization * Update WorkspaceModel.cs * remove grid style (not needed anymore) * Remove BelongsToGroup property from ModelBase * Update AnnotationViewModel.cs * fix setting the graph to have unsaved changes on graph open * disable drag and drop on collapsed groups * fix spelling mistake
* Code Cleanup * Call Dispose() on ConnectorAnchorViewModel * unsub collection change * formatting fix broken path to pin icon * revert schema change * revert schema change in serialization as well * actually dispose annotationviewmodels Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: michael kirschner <[email protected]>
* Fix non clickable textboxes * use nameof * Update AnnotationViewTests.cs
Contributor
Author
|
@mjkkirschner Strange enough, I noticed the parallel CI has been passing for Group improvements after some crash level fixes by @SHKnudsen recently. The latest job triggered by me is passing here https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/3589/. There is another job by system timer, if that one also pass, we may consider bring the feature in. Any objections? |
QilongTang
changed the title
QilongTang
commented
Sep 8, 2021
Contributor
Author
|
@reddyashish @zeusongit This PR covers the previously reviewed group improvement PR and the recent ones, since parallel CI now passing. I am merging now to bring it into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Group Improvements done by @SHKnudsen . Initial PR at #11912 and there are some follow up PRs about crash level bug fixes and minor improvements.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of