Skip to content

Node Info States#12011

Closed
OliverEGreen wants to merge 0 commit intoDynamoDS:UIRefreshNodeStatesfrom
OliverEGreen:UI_Refresh_node_info_states
Closed

Node Info States#12011
OliverEGreen wants to merge 0 commit intoDynamoDS:UIRefreshNodeStatesfrom
OliverEGreen:UI_Refresh_node_info_states

Conversation

@OliverEGreen
Copy link
Contributor

This PR adds in the node informational states functionality.

It has been carried over from this PR: #11997

It reponds to this issue:
[DYN-3960] https://jira.autodesk.com/browse/DYN-3960

}
// Clearing and recreating all existing warning-level messages from the dismissed collection.
RefreshDismissedMessages(InfoBubbleViewModel.Style.Warning);
RefreshDismissedMessages(InfoBubbleViewModel.Style.WarningCondensed);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I thought this style is obsoleted, do we still need to refresh it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Condensed styles? They're catered for so as to not break any part of the existing API, but yes they're effectively no longer necessary.

@QilongTang
Copy link
Contributor

Running self CI again

@QilongTang
Copy link
Contributor

From the previous CI, the CI reporting some number of regressions.
image

@QilongTang
Copy link
Contributor

@OliverEGreen any update to this PR about the regressions?

@OliverEGreen
Copy link
Contributor Author

@OliverEGreen any update to this PR about the regressions?

Hi @QilongTang, I have been focusing on other work recently but this is not forgotten!
Will need to add the mouseover/collapsing behaviour we discussed in this week's call to the branch as well.

@OliverEGreen
Copy link
Contributor Author

From the previous CI, the CI reporting some number of regressions.
image

I've run all of these tests locally and they passed:

image
image

@OliverEGreen OliverEGreen mentioned this pull request Sep 28, 2021
8 tasks
@OliverEGreen OliverEGreen deleted the UI_Refresh_node_info_states branch November 9, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants