Node Info States#12011
Closed
OliverEGreen wants to merge 0 commit intoDynamoDS:UIRefreshNodeStatesfrom
OliverEGreen:UI_Refresh_node_info_states
Closed
Node Info States#12011OliverEGreen wants to merge 0 commit intoDynamoDS:UIRefreshNodeStatesfrom OliverEGreen:UI_Refresh_node_info_states
OliverEGreen wants to merge 0 commit intoDynamoDS:UIRefreshNodeStatesfrom
OliverEGreen:UI_Refresh_node_info_states
Conversation
QilongTang
reviewed
Sep 7, 2021
QilongTang
reviewed
Sep 8, 2021
QilongTang
reviewed
Sep 8, 2021
QilongTang
reviewed
Sep 8, 2021
QilongTang
reviewed
Sep 8, 2021
| } | ||
| // Clearing and recreating all existing warning-level messages from the dismissed collection. | ||
| RefreshDismissedMessages(InfoBubbleViewModel.Style.Warning); | ||
| RefreshDismissedMessages(InfoBubbleViewModel.Style.WarningCondensed); |
Contributor
There was a problem hiding this comment.
hmm I thought this style is obsoleted, do we still need to refresh it?
Contributor
Author
There was a problem hiding this comment.
The Condensed styles? They're catered for so as to not break any part of the existing API, but yes they're effectively no longer necessary.
QilongTang
reviewed
Sep 8, 2021
QilongTang
reviewed
Sep 8, 2021
Contributor
|
Running self CI again |
Contributor
Contributor
|
@OliverEGreen any update to this PR about the regressions? |
Contributor
Author
Hi @QilongTang, I have been focusing on other work recently but this is not forgotten! |
Contributor
Author
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR adds in the node informational states functionality.
It has been carried over from this PR: #11997
It reponds to this issue:
[DYN-3960] https://jira.autodesk.com/browse/DYN-3960