[DYN-3981] Clicking on the output port of a group crashes dynamo#12008
Merged
QilongTang merged 1 commit intoDynamoDS:UIRefreshGroupImprovementsfrom Sep 7, 2021
Conversation
SHKnudsen
force-pushed
the
DYN-3981-Clicking-on-the-output-port-of-a-group-crashes-dynamo
branch
from
f1ea79b to
4a4d14f
Compare
SHKnudsen
force-pushed
the
DYN-3981-Clicking-on-the-output-port-of-a-group-crashes-dynamo
branch
from
4a4d14f to
ee743f0
Compare
QilongTang
approved these changes
Sep 6, 2021
QilongTang
added a commit
that referenced
this pull request
Sep 8, 2021
* Group improvements to the graph view (#11912) * initial commit * wip * clean up * remove leftovers * UndoRedo behaviour + grouped groups cut out + general fixes * update images * fix CopyPaste + few minor bugs * minor clean ups * Group improvements unit tests (#29) * WIP * view model tests * initial commit * wip * clean up * remove leftovers * UndoRedo behaviour + grouped groups cut out + general fixes * update images * fix CopyPaste + few minor bugs * minor clean ups * Update SerializationTests.cs * Update SerializationTests.cs * comment updates * comment updates * fix GetOutputPorts errors * fix serialization * Update WorkspaceModel.cs * remove grid style (not needed anymore) * Remove BelongsToGroup property from ModelBase * Update AnnotationViewModel.cs * fix setting the graph to have unsaved changes on graph open * disable drag and drop on collapsed groups * fix spelling mistake * Node redesign timeouts (#11986) * Code Cleanup * Call Dispose() on ConnectorAnchorViewModel * unsub collection change * formatting fix broken path to pin icon * revert schema change * revert schema change in serialization as well * actually dispose annotationviewmodels Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: michael kirschner <[email protected]> * [DYN-3975] Fix non clickable textboxes (#12007) * Fix non clickable textboxes * use nameof * Update AnnotationViewTests.cs * Change output port background (#12017) * SelectAll after node has been dragged into group (#12010) * Remove ProxyPortModel creation (#12008) * Update AnnotationView.xaml (#12022) * code clean up Co-authored-by: Sylvester Knudsen <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: michael kirschner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR handles DYN-3981.
The issue here was that the creating a ProxyPortModel will no currently work as the proxyModel won't be a part of the nodeModels port collections and therefore it wont be able to return a valid port index, which is what was causing the crash.
The solution, for now, was to remove the ProxyPortModel creation and simply pass the PortModel to the ProxyPortViewModel instead.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang