[DYN-3975] Fix non clickable textboxes#12007
Merged
QilongTang merged 3 commits intoDynamoDS:UIRefreshGroupImprovementsfrom Sep 3, 2021
Merged
[DYN-3975] Fix non clickable textboxes#12007QilongTang merged 3 commits intoDynamoDS:UIRefreshGroupImprovementsfrom
QilongTang merged 3 commits intoDynamoDS:UIRefreshGroupImprovementsfrom
Conversation
QilongTang
reviewed
Sep 2, 2021
QilongTang
reviewed
Sep 2, 2021
QilongTang
reviewed
Sep 2, 2021
QilongTang
approved these changes
Sep 2, 2021
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Similar to #12006, waiting for PR checks to pass. LGTM
Contributor
|
If the PR checks still failing for crashes, then we will need to investigate further unfortunately |
SHKnudsen
force-pushed
the
DYN-3975-Fix-non-clickable-textboxes
branch
from
be7eb83 to
71b6e8a
Compare
SHKnudsen
commented
Sep 3, 2021
| annotationView.ViewModel.FontSize = 48; | ||
|
|
||
| //Group textblock should be visible. | ||
| Assert.IsTrue(annotationView.GroupTextBlock.IsVisible); |
Contributor
Author
There was a problem hiding this comment.
@QilongTang FYI modified this test as the visibility checks does not really apply anymore. Unless we want to turn the hide on specific zoom back
Contributor
There was a problem hiding this comment.
Thanks I dont think that is required, @Amoursol @Jingyi-Wen can you confirm?
QilongTang
added a commit
that referenced
this pull request
Sep 8, 2021
* Group improvements to the graph view (#11912) * initial commit * wip * clean up * remove leftovers * UndoRedo behaviour + grouped groups cut out + general fixes * update images * fix CopyPaste + few minor bugs * minor clean ups * Group improvements unit tests (#29) * WIP * view model tests * initial commit * wip * clean up * remove leftovers * UndoRedo behaviour + grouped groups cut out + general fixes * update images * fix CopyPaste + few minor bugs * minor clean ups * Update SerializationTests.cs * Update SerializationTests.cs * comment updates * comment updates * fix GetOutputPorts errors * fix serialization * Update WorkspaceModel.cs * remove grid style (not needed anymore) * Remove BelongsToGroup property from ModelBase * Update AnnotationViewModel.cs * fix setting the graph to have unsaved changes on graph open * disable drag and drop on collapsed groups * fix spelling mistake * Node redesign timeouts (#11986) * Code Cleanup * Call Dispose() on ConnectorAnchorViewModel * unsub collection change * formatting fix broken path to pin icon * revert schema change * revert schema change in serialization as well * actually dispose annotationviewmodels Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: michael kirschner <[email protected]> * [DYN-3975] Fix non clickable textboxes (#12007) * Fix non clickable textboxes * use nameof * Update AnnotationViewTests.cs * Change output port background (#12017) * SelectAll after node has been dragged into group (#12010) * Remove ProxyPortModel creation (#12008) * Update AnnotationView.xaml (#12022) * code clean up Co-authored-by: Sylvester Knudsen <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: michael kirschner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
this PR fixes:
The event triggers that handle editing the Group textboxes have been moved into the
TextBlockGridas they need to handle click events on theGroupNameControlandGroupDescriptionControlswhich are both inside this grid.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@mjkkirschner