Skip to content

Node informational states#11997

Closed
OliverEGreen wants to merge 105 commits intoDynamoDS:UIRefreshNodeStatesfrom
OliverEGreen:node_informational_states
Closed

Node informational states#11997
OliverEGreen wants to merge 105 commits intoDynamoDS:UIRefreshNodeStatesfrom
OliverEGreen:node_informational_states

Conversation

@OliverEGreen
Copy link
Contributor

Removes the ObservableCollection in each node's context menu, replacing it with a collection of strings instead.
Attempts to serialize/deserialize dismissed warnings as strings.

Simplification of some error/warning/info collection logic, and refactors some repetitive code.

OliverEGreen and others added 30 commits July 6, 2021 10:48
Adds Artifakt font, changes colors, port/header height config, code block editor colours.
* Updates node styling

* Updates UI

Adds Artifakt font, changes colors, port/header height config, code block editor colours.

* Update UI

* Updates UI

* Updates UI

* Updates UI

* Ports visual states are working.

* Revert "Ports visual states are working."

* Revert "Revert "Ports visual states are working.""

This reverts commit 3557726.

* Updates UI

* Updates ContextMenu style

* Updates UI

* Updates UI

* Updates ComboBox and Output Ports style for Code Blocks

* Loads icon to node header

* Updates UI

* Updates UI

* Updates UI

* Bug fixes and responding to comments

* DYN-3875: Restore LocalPackages property in PreferencesViewModel (#11881)

* restore property in PreferencesViewModel

* add regression test for installedpackagesview

* fix test

* remove setting datacontext for installed packages view control as it is inherited

* undo unnecessary changes

* more cleanup

* Updates UI

* fix node autocomplete crash (#11887)

* Minor UI changes to Autodesk feedback

* Temporarily disabled dismissed alerts features

* Minor UI fix to the nodes' GlyphStackPanel

Co-authored-by: aparajit-pratap <[email protected]>
* DYN-3768-SurveyWindowUI (#11834)

* DYN-3768-SurveyWindowUI

I created 3 resources for the two titles of the SurveyWindow and one for the text content.
I modified the CustomRichTextBox because hyperlink names separated by spaces were not supported then I did some changes and now are working.
I added the RatingControl UI and the SurveyPopup UI and some used styles in the DynamoModern.xaml.
Finally I added a instance of the Survey in the DynamoView.xaml.cs and now a survey popup will be displayed just for testing purposes.

* DYN-3768-SurveyWindowUI Code Review

I added several comments in SurveyPopupViewModel and RatingControl and removed a comment Survey

* DYN-3768-SurveyWindowUI Code Review2

Updated the DependencyProperty name to Value

* Update and rename 4_stdlib.md to 4_builtinpackages.md (#11850)

* Update and rename 4_stdlib.md to 4_builtinpackages.md

* Update 4_builtinpackages.md

* Add ways to pass Analytics Host Entitlement info for out of process integrators (#11841)

* Initial Commit

* Add ParentId to update manager

* Updates

* Add CLI support

* Add unit tests

* Update tests

* Update HostContextInfo type usage

* Comments to use struct

* Move properties out of update manager

* Update

* Comments

* Comments

* update test

* Force Dynamo to run on nvidia graphics card to address helix crash with multiple monitors (#11855)

* enable nvidia graphics card for helix

* make new field private

* Triggering Node AutoComplete on input port should not destroy the connection. (#11859)

* Extension fix (#11861)

DYN-3773

* Upgrade Helix to 2.17.0. (#11860)

* DYN-3834-GeoScaling-GraphRun (#11845)

* DYN-3834-GeoScaling-GraphRun

There was an issue that when the Geometry Scaling was updated in a very large graph the Preferences panel was blocked not allowing the user to close it. I think this behavior was because when the Preference panel was opened immediately a graph run was executed (without changing anything in the Preferences panel).
I was NOT able to reproduce the Preferences panel freezing behavior but we noticed that the graph execution was always happening when the Preferences panel was opened (when nothing was changed), then I did a fix in a way that the selected radio button (in geometry scaling section) is updated every time a new workspace is created or a dyn file is loaded (as is happening with the WorkspaceModel.ScaleFactor), so the graph run will be executed just when the ScaleFactor is changed.

* DYN-3834-GeoScaling-GraphRun Code Review

Unsubscribing from the WorkspaceSettingsChanged when the PreferencesViewModel is cleared.

* DYN-3834-GeoScaling-GraphRun Code Review

Making method private due that is just used in the same class.

* DYN-3834-GeoScaling-GraphRun Code Review

I did some changes so only when the ScaleFactor was changed a graph run will be executed when the Preferences dialog is closed

* DYN-3834-GeoScaling-GraphRun Code Review2

Replacing the call to ForceRunCancelCommand method for MarkNodesAsModifiedAndRequestRun due that the first one was executing the graph when the RunMode = Manual at the moment of updating the Geometry Scaling in the other hand with the MarkNodesAsModifiedAndRequestRun doesn't happen that behavior.

* Pin Note to Node (#11840)

* Pin to node squashed commit

* Changes for pin to node pr

* Add spacing to pin icon

* Retain pin node in copy paste, also correct spacing between note pin icon and text

* Move selection to command

* Place PIN_WIDTH as constant

* Fix distance in unit tests

* update libG for perimeter curves refactor (#11870)

Co-authored-by: pinzart <[email protected]>

* add test for dyn-3628 fix (#11872)

* add dump bytecode debug mode (#11871)

* add dump bytecode debug mode

* DYN-3815 - Prevent reloading of packages unless there are new packages in list of package paths (#11835)

* initial commit - WIP

* fixes for extraneous notifications and duplicate nodes

* cleanup

* revert unchanged file

* fix new package logic

* remove unused property

* fix some tests

* revert unchanged file

* fix remaining tests

* obsolete property

* cleanup

* edit obsoletion message

* load loose custom node defn files by simply adding root path

* add unit tests

* review comments

* revert rename of public API

* unsub events in tests

* DYN-3834-GeoScaling-UnitTest (#11867)

* DYN-3834-GeoScaling-UnitTest

I added one unit tests with two parameters, one is for validating that when RunMode=Manual and the MarkNodesAsModifiedAndRequestRun() method is called the graph execution is NOT kicked off.
The other when the RunMode=Automatic and the MarkNodesAsModifiedAndRequestRun() method is called the graph execution is kicked off.

* DYN-3834-GeoScaling-UnitTest Code Review

I had to split the tests in two (one for Automatic and other for Manual) due that the Resources strings can not be used as a parameters in nUnit Tests parameters (since parameters expected should be constant values).

* DYN-3834-GeoScaling-UnitTest Code Review2

Adding extra assert before validating the node warning state.
A comment was updated reflecting the behavior when RunType = Manual

* Pin to Node Selection Behaivior (#11874)

* Pin to node squashed commit

* Changes for pin to node pr

* Add spacing to pin icon

* Retain pin node in copy paste, also correct spacing between note pin icon and text

* Move selection to command

* Place PIN_WIDTH as constant

* Fix distance in unit tests

* Selection behaviour corrected

* Limit pin to node behaviour

* Add tooltip for Pin to node command,
Enable Pin To Node only when a node and a note is selected

* Add test to PinToNodeCommand.canExecute

* Update ScopeIf description (#11876)

* Update ScopeIf description

* ScopeIf Description Update

* Update Resources.Designer.cs

* DYN-3875: Restore LocalPackages property in PreferencesViewModel (#11881)

* restore property in PreferencesViewModel

* add regression test for installedpackagesview

* fix test

* remove setting datacontext for installed packages view control as it is inherited

* undo unnecessary changes

* more cleanup

* fix node autocomplete crash (#11887)

* Node redesign (#3)

* Updates node styling

* Updates UI

Adds Artifakt font, changes colors, port/header height config, code block editor colours.

* Update UI

* Updates UI

* Updates UI

* Updates UI

* Ports visual states are working.

* Revert "Ports visual states are working."

* Revert "Revert "Ports visual states are working.""

This reverts commit 3557726.

* Updates UI

* Updates ContextMenu style

* Updates UI

* Updates UI

* Updates ComboBox and Output Ports style for Code Blocks

* Loads icon to node header

* Updates UI

* Updates UI

* Updates UI

* Bug fixes and responding to comments

* DYN-3875: Restore LocalPackages property in PreferencesViewModel (#11881)

* restore property in PreferencesViewModel

* add regression test for installedpackagesview

* fix test

* remove setting datacontext for installed packages view control as it is inherited

* undo unnecessary changes

* more cleanup

* Updates UI

* fix node autocomplete crash (#11887)

* Minor UI changes to Autodesk feedback

* Temporarily disabled dismissed alerts features

* Minor UI fix to the nodes' GlyphStackPanel

Co-authored-by: aparajit-pratap <[email protected]>

Co-authored-by: Roberto T <[email protected]>
Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: aparajit-pratap <[email protected]>
Co-authored-by: reddyashish <[email protected]>
Co-authored-by: Ashish Aggarwal <[email protected]>
Co-authored-by: Jorgen Dahl <[email protected]>
Co-authored-by: Martin Stacey <[email protected]>
Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Sol Amour <[email protected]>
OliverEGreen and others added 21 commits August 26, 2021 10:21
Adds new resource strings.
Adds a ToolTip for the node context menu.
Makes node context menu visible for all nodes.
Fixes error bubble Z Index issue.
Adds chevron to error bubble design.
Unsubscribes from NodeMessages.CollectionChanged on InfoBubbleViewModel's Dispose method.
* initial commit

* wip

* clean up

* remove leftovers

* UndoRedo behaviour + grouped groups cut out + general fixes

* update images

* fix CopyPaste + few minor bugs

* minor clean ups

* Group improvements unit tests (#29)

* WIP

* view model tests

* initial commit

* wip

* clean up

* remove leftovers

* UndoRedo behaviour + grouped groups cut out + general fixes

* update images

* fix CopyPaste + few minor bugs

* minor clean ups

* Update SerializationTests.cs

* Update SerializationTests.cs

* comment updates

* comment updates

* fix GetOutputPorts errors

* fix serialization

* Update WorkspaceModel.cs

* remove grid style (not needed anymore)

* Remove BelongsToGroup property from ModelBase

* Update AnnotationViewModel.cs

* fix setting the graph to have unsaved changes on graph open

* disable drag and drop on collapsed groups

* fix spelling mistake
* Updates node styling

* Updates UI

Adds Artifakt font, changes colors, port/header height config, code block editor colours.

* Update UI

* Updates UI

* Updates UI

* Updates UI

* Ports visual states are working.

* Revert "Ports visual states are working."

* Revert "Revert "Ports visual states are working.""

This reverts commit 3557726.

* Updates UI

* Updates ContextMenu style

* Updates UI

* Updates UI

* Updates ComboBox and Output Ports style for Code Blocks

* Loads icon to node header

* Updates UI

* Updates UI

* Updates UI

* Bug fixes and responding to comments

* Updates UI

* WIP changes

* ViewModel logic working as per mockup

* Node redesign (#3)

* Updates node styling

* Updates UI

Adds Artifakt font, changes colors, port/header height config, code block editor colours.

* Update UI

* Updates UI

* Updates UI

* Updates UI

* Ports visual states are working.

* Revert "Ports visual states are working."

* Revert "Revert "Ports visual states are working.""

This reverts commit 3557726.

* Updates UI

* Updates ContextMenu style

* Updates UI

* Updates UI

* Updates ComboBox and Output Ports style for Code Blocks

* Loads icon to node header

* Updates UI

* Updates UI

* Updates UI

* Bug fixes and responding to comments

* DYN-3875: Restore LocalPackages property in PreferencesViewModel (#11881)

* restore property in PreferencesViewModel

* add regression test for installedpackagesview

* fix test

* remove setting datacontext for installed packages view control as it is inherited

* undo unnecessary changes

* more cleanup

* Updates UI

* fix node autocomplete crash (#11887)

* Minor UI changes to Autodesk feedback

* Temporarily disabled dismissed alerts features

* Minor UI fix to the nodes' GlyphStackPanel

Co-authored-by: aparajit-pratap <[email protected]>

* Updates

* Updates node informational states

* Minor fixes

* Removed INodeInformationalState interface, no longer needed.

* Restored previously-removed commands in InfoBubbleCommand.cs

* Typo fix and restoring old NodeInfoBubbleViewModel methods to original state.

* Added comments, minor (old) API restoration work

* Renaming, refactoring and added 2 tests.

* Removed new constructor for OutputMessage.

Class is no longer being used for Informational States.

* Minor fixes.

Removed outdated and unused collection on NodeModel.
Changed command name to be less confusing.

* Update

* Responds to comments

* Removed unneeded references

* Reponse to comments

* Removed 'else' from method body

* two more

* Fixes UI bug

* Switched out vector-based info/warning/error icons for .png equivalents.

* Removes reference to WindowsBase in DynamoCore and flags many properties in the InfoBubbleViewModel as obsolete.

* Updates

* Minor graphical updates

* Updates in response to feedback

Adds new resource strings.
Adds a ToolTip for the node context menu.
Makes node context menu visible for all nodes.
Fixes error bubble Z Index issue.
Adds chevron to error bubble design.
Unsubscribes from NodeMessages.CollectionChanged on InfoBubbleViewModel's Dispose method.

Co-authored-by: aparajit-pratap <[email protected]>
* Code Cleanup

* Call Dispose() on ConnectorAnchorViewModel
* Code Cleanup

* Call Dispose() on ConnectorAnchorViewModel

* unsub collection change

* formatting
fix broken path to pin icon

* revert schema change

* revert schema change in serialization as well

* actually dispose annotationviewmodels

Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: michael kirschner <[email protected]>
* ConnectorViewModel dispose

* More Dispose spots
Updates InfoBubbleViewModel ZIndex property to the desired behaviour (dynamically linked to node ZIndex + 1).
Removes the de/serialization of Dismissed Alerts for now.
@QilongTang QilongTang changed the base branch from DynamoNodeRedesign to UIRefreshNodeStates September 2, 2021 11:16
@QilongTang QilongTang changed the base branch from UIRefreshNodeStates to DynamoNodeRedesign September 2, 2021 11:16
@QilongTang
Copy link
Contributor

@OliverEGreen OliverEGreen changed the base branch from DynamoNodeRedesign to UIRefreshNodeStates September 2, 2021 14:42
@OliverEGreen
Copy link
Contributor Author

Hi @QilongTang, I've rebased this PR as requested

@OliverEGreen OliverEGreen mentioned this pull request Sep 2, 2021
@OliverEGreen OliverEGreen mentioned this pull request Sep 28, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants