move package search paths to preferences settings by mjkkirschner · Pull Request #11762 · DynamoDS/Dynamo

mjkkirschner · 2021-06-15T19:20:09Z

Purpose

This PR moves the node and package dialog to the package prefs settings dialog.

PackagePathView and PackagePathViewModel are reused but heavily modified.
Since the new design does not (need or) support selection of the paths, the selectedIndex property is obsoleted and disconnected from the UI - it now serves no purpose.
I've tried to reuse some styles from the modern dynamo dictionary
adds some colors to the dictionary
renames RemoveStyleButtonStyle template to FlatIconButtonStyle.
The commands that are used to bind to the buttons are unchanged, but their implementations no longer use selectedIndex instead relying on the bound path of the current button - that path is converted to an index by looking up the path in the RootLocations property of the PackagePathViewModel.
adds package manager to preference settings tabs so expander state is preserved.
packagePathView is no longer a window - now a user control.
modifies the expander styles to make the header text size 14 and medium (though maybe it should be full bold?)
package paths are committed on close of the prefs window, and packages re reloaded.

Feedback requested

⚠️ one thing I'm not sure about - is that the packages are reloaded and paths saved whenever the preferences window is closed, this means that if you open the preferences to change some random setting having nothing to do with package paths, then close the prefs window, you will see some notifications about packages that were ignored because they were already loaded - I think we should fix this issue of expected warnings in a followup task -it's an issue today as well, but this pr will make it more frequent. I'm not sure if this is tracked - but I do know @sm6srw brought it up.

TODO

This screenshot shows what happens if we turn on the hidden DisableCustomPackagePaths flag.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

remove unusued setter add property for packagePathsViewModel to prefsViewModel construct packpathsVMwhen creating prefsVM add item template, button, and itemcontrol first draft

rename property for viewmodel make internal commands work for ints or string paths temporarily fix for making packagepathsview a usercontrol - will remove this code when done use new control in prefs modify packagePathView deal with the fact that dataContext for packagePathView will be late bound and will change from null to PackagePathViewModel. this currently will add and remove paths correctly - other commands are not modified yet, no data is saved to prefs xml on dynamo close - and package reload is not implemented on prefs close yet.

convert paths to indices before calling internal command implementations add namespace for packages hook up command bindings for each button to pass path as parameter - bind to packagepathViewModel remove old code from packagePathView for selection we no longer need

…chpathslist

scroll expander

scroll bar bigger area

remove unused static var save packages and load them on prefs close use datatrigger to grey out disabled paths

fix tests

add new tests

src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs

mjkkirschner · 2021-06-17T21:18:30Z

src/DynamoCoreWpf/UI/Themes/Modern/DynamoModern.xaml

+        <TextBlock
+            Text="{Binding}" 
+            FontSize="14"
+            FontWeight="Medium">


I think this will probably do something once we change all the fonts to Artifakt.

src/DynamoCoreWpf/DynamoCoreWpf.csproj

src/DynamoCoreWpf/ViewModels/PackageManager/PackagePathViewModel.cs

src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml

src/DynamoCoreWpf/Views/PackageManager/PackagePathView.xaml

src/DynamoCoreWpf/Views/PackageManager/PackagePathView.xaml.cs

obsolete dialog raise events and request methods remove event subscription

into searchpathslist

pinzart90

LGTM

aparajit-pratap · 2021-06-21T16:24:12Z

@mjkkirschner are the packages reloaded even when there is no change to the package paths? What about when some other tab other than the "package manager" tab of the preferences dialog is opened?

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

src/DynamoCoreWpf/ViewModels/PackageManager/PackagePathViewModel.cs

src/DynamoCoreWpf/Views/PackageManager/PackagePathView.xaml.cs

mjkkirschner · 2021-06-21T17:36:51Z

@mjkkirschner are the packages reloaded even when there is no change to the package paths? What about when some other tab other than the "package manager" tab of the preferences dialog is opened?

yes, and yes - I've mentioned this in the description of this pr.
I'd like to get this merged without addressing it at the moment, I think it might be a bit tricky.

…chpathslist

mjkkirschner added 4 commits June 11, 2021 15:30

add new color for dark backgrounds

2e542ca

remove unusued setter add property for packagePathsViewModel to prefsViewModel construct packpathsVMwhen creating prefsVM add item template, button, and itemcontrol first draft

missed

9952bf2

mjkkirschner added the WIP label Jun 15, 2021

mjkkirschner added 10 commits June 16, 2021 11:20

Merge branch 'master' of https://github.com/DynamoDS/Dynamo into sear…

560d207

…chpathslist

tweak some margins

11aefcb

new icons

5b59f9e

scroll expander

expander bigger font

ea02e3e

scroll bar bigger area

change all expander headers to 14pt font, medium

4e7925c

add isdisabled helper

768e9f5

remove unused static var save packages and load them on prefs close use datatrigger to grey out disabled paths

missed

5530b7c

fix tooltips

cea771d

fix tests

add new icons

f0c149e

fix bug

a58d6e8

add new tests

mjkkirschner added PTAL Please Take A Look 👀 and removed WIP labels Jun 17, 2021

mjkkirschner commented Jun 17, 2021

View reviewed changes

src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs Outdated Show resolved Hide resolved

mjkkirschner requested a review from sm6srw June 17, 2021 20:57

mjkkirschner added 2 commits June 17, 2021 17:12

update resx

e52eb79

fix the build - typo

5ec29ba

mjkkirschner commented Jun 17, 2021

View reviewed changes

mjkkirschner requested a review from pinzart90 June 18, 2021 14:53