Skip to content

Packages expander panel in the Workspace References panel#11744

Merged
reddyashish merged 7 commits intoDynamoDS:masterfrom
reddyashish:master
Jun 11, 2021
Merged

Packages expander panel in the Workspace References panel#11744
reddyashish merged 7 commits intoDynamoDS:masterfrom
reddyashish:master

Conversation

@reddyashish
Copy link
Collaborator

@reddyashish reddyashish commented Jun 9, 2021 •
edited
Loading

Purpose

Task: https://jira.autodesk.com/browse/DYN-2218

This PR is to create Packages expander and extend that to non-package dependencies.

Screen Shot 2021-06-09 at 11 38 23 AM

Screen Shot 2021-06-09 at 11 38 34 AM

TODO:

  1. Review with the UX team.
  2. Any tests that would be needed.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@DynamoDS/dynamo

@reddyashish reddyashish added the DNM Do not merge. For PRs. label Jun 9, 2021
@QilongTang
Copy link
Contributor

QilongTang commented Jun 9, 2021

@Jingyi-Wen Did we finalize where the refresh button should be, e.g on expander or inside? Or let me put it this way, is the current way shown by @reddyashish fine to proceed for now :)

@reddyashish
Copy link
Collaborator Author

reddyashish commented Jun 9, 2021

@QilongTang @Jingyi-Wen As I am using the same expander styling used in preferences panel, I had left the refresh button where it was before for now. It might get little tricky to place it inside the expander but if you think that would be better, I can look into some solution.

@QilongTang
Copy link
Contributor

QilongTang commented Jun 9, 2021

@QilongTang @Jingyi-Wen As I am using the same expander styling used in preferences panel, I had left the refresh button where it was before for now. It might get little tricky to place it inside the expander but if you think that would be better, I can look into some solution.

Cool, I dont have a preference for this one.

@Jingyi-Wen
Copy link

Jingyi-Wen commented Jun 9, 2021

@QilongTang @Jingyi-Wen As I am using the same expander styling used in preferences panel, I had left the refresh button where it was before for now. It might get little tricky to place it inside the expander but if you think that would be better, I can look into some solution.

Cool, I dont have a preference for this one.

I was a little bit hesitant about the same thing. I think this current location looks good. Let's not risk messing up with the expanding behavior then

@reddyashish reddyashish changed the title [WIP] Packages expander panel in the Workspace References panel Packages expander panel in the Workspace References panel Jun 11, 2021
@reddyashish reddyashish removed the DNM Do not merge. For PRs. label Jun 11, 2021
QilongTang
QilongTang reviewed Jun 11, 2021
View reviewed changes
QilongTang
QilongTang approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reddyashish reddyashish merged commit 1fc5108 into DynamoDS:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reddyashish @QilongTang @Jingyi-Wen