add new package manager prefs section#11734
Conversation
add new tab increase tab width increase window width
|
@Jingyi-Wen Can you take a look? The new sub panel tabs looks a bit strange to me, and I wonder if we can make the tabs wider and wordwrap instead of having to make the whole dialog wider? @RobertGlobant20 What do you think? |
Looking at other tabs we already have, I think we can make the tabs wider for all of them and leave the dialog width as it is |
|
@Jingyi-Wen if we don't make the dialog wider, then some content wraps in strange ways, let me get you a screenshot. |
|
I'm remembering wrong- Do you have a preference @Jingyi-Wen? The faster I get this merged, the faster we can move on to other UI for the package manager prefs. |
@mjkkirschner Maybe we wrap the localization problem into a different task and PR? I feel the impact is larger than we thought? |
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Looks promising. @mjkkirschner Once comments addressed, LGTM
use existing resource string for installed packages
| RadioMediumDesc.Inlines.Add(" " + viewModel.OptionsGeometryScale.DescriptionScaleRange[1]); | ||
|
|
||
| RadioLargeDesc.Inlines.Add(viewModel.OptionsGeometryScale.DescriptionScaleRange[1]); | ||
| RadioLargeDesc.Inlines.Add(viewModel.OptionsGeometryScale.DescriptionScaleRange[2]); |
There was a problem hiding this comment.
geometry scaling descriptions were repeated for medium and large, and extra large was wrong.
@QilongTang I'm not sure about the consequences of making the tabs wider and wordwrap (without making the dialog wider). but as I was guessing if the tabs (and content) width changes we will face several alignment problems like the text in the Geometry Scaling expander. |
|
I'm going to merge this after one more test run. |
RobertGlobant20
left a comment
RobertGlobant20
left a comment
There was a problem hiding this comment.
LGTM, @mjkkirschner could you include a screenshot of the Features and Visual Settingstab after changing the TabPanel.Width
5 participants
Purpose
adds a new tab for package manager client settings.
adds expanders with empty labels to be filled in.
increases width of tabs by 50 pixels.
increases width of window by 50pixels.renames some methods to follow c# naming standards.
fixes a bug with the labels for geometry scaling- both medium and large had the same description.
I would like to make the window resizable horizontally to deal with localized text being longer - but need to check with Morpheus team if that is okay.We're going to wait on this.Declarations
Check these if you believe they are true
*.resxfiles