Add tests for the new IF node.#11721
Merged
reddyashish merged 1 commit intoDynamoDS:RefactoredIfNodefrom Jun 2, 2021
Merged
Conversation
QilongTang
approved these changes
Jun 1, 2021
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM What do you think @aparajit-pratap
Collaborator
Author
|
@aparajit-pratap Merging this for now and will create a merge PR from this branch to master to get new IF node changes. Let me know if you of any changes and I will look into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to add tests around Lacing, ListAtLevel and Partial function features for the new IF node
There are some tests in "IfTest" fixture that are testing the old "IF" node. Do we want to keep them around to support the old node or do we plan to replace the tests with the new node?
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@aparajit-pratap @QilongTang