Fixing Harcoded String#11720
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Jun 1, 2021
RobertGlobant20:Fix_Harcoded_String
Merged
Fixing Harcoded String#11720QilongTang merged 2 commits intoDynamoDS:masterfrom RobertGlobant20:Fix_Harcoded_String
QilongTang merged 2 commits intoDynamoDS:masterfrom
RobertGlobant20:Fix_Harcoded_String
Conversation
Fixing Harcoded String in the PreferencesView, so it was moved to resources
QilongTang
requested changes
Jun 1, 2021
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
There is already a res string called PreferencesViewIsIronPythonDialogDisabled with the same value
Reusing the Resource PreferencesViewIsIronPythonDialogDisabled instead of creating a new one.
Contributor
Author
|
QilongTang
approved these changes
Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing harcoded string in the PreferencesView, so it was moved to resources.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@mjkkirschner