Fix Expander Expanding Functionality#11717
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom May 28, 2021
RobertGlobant20:Fix_Expanders_Issue
Merged
Fix Expander Expanding Functionality#11717QilongTang merged 2 commits intoDynamoDS:masterfrom RobertGlobant20:Fix_Expanders_Issue
QilongTang merged 2 commits intoDynamoDS:masterfrom
RobertGlobant20:Fix_Expanders_Issue
Conversation
Fixing the issue "clicking on header of an expanded Expander doesn't collapse it. Hence, there is no way to collapse all the expanders once one of them is expanded." I removed the Expanded event since it was producing saving wrong expanded status per each expander.
QilongTang
reviewed
May 28, 2021
| } | ||
| else | ||
| { | ||
| expanderActive = ""; |
Contributor
Author
There was a problem hiding this comment.
@QilongTang
Fixed in the next commit: aebc3ae
Fixing one code review comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing the issue reported during texting "clicking on header of an expanded Expander doesn't collapse it. Hence, there is no way to collapse all the expanders once one of them is expanded."
I removed the Expanded event since it was producing saving wrong expanded status per each expander.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@Astul-Betizagasti