Skip to content

Move Geometry Scaling setting into general section of preferences#11716

Merged
reddyashish merged 1 commit intoDynamoDS:masterfrom
reddyashish:master
May 29, 2021
Merged

Move Geometry Scaling setting into general section of preferences#11716
reddyashish merged 1 commit intoDynamoDS:masterfrom
reddyashish:master

Conversation

@reddyashish
Copy link
Collaborator

@reddyashish reddyashish commented May 27, 2021

Purpose

This change is to move the Geometry scaling setting into the General sub-panel of the preferences window.

Task: https://jira.autodesk.com/browse/DYN-3689

Preferences

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang @zeusongit @Jingyi-Wen @Amoursol

@QilongTang
Copy link
Contributor

Hi @reddyashish this looks good, other than added a scroll bar to General subpanel, is there any major change we should note for Aabi?

@reddyashish reddyashish reopened this May 28, 2021
@reddyashish
Copy link
Collaborator Author

@QilongTang I lost the changes by mistake. Committed the same changes again and resolved the conflicts.

The Scroll bar is the only main change. In testing, we will have to make sure that everything is space-aligned accordingly.

@reddyashish reddyashish merged commit 3a98f3f into DynamoDS:master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants