Use Double Left Click to trigger NodeAutoComplete#11710
Merged
QilongTang merged 1 commit intomasterfrom May 25, 2021
Merged
Conversation
12 tasks
QilongTang
commented
May 25, 2021
| owningWorkspace.CurrentCursor = CursorLibrary.GetCursor(CursorSet.ArcSelect); | ||
| owningWorkspace.IsCursorForced = false; | ||
| return true; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Deleting the old code handling Alt+ mouse left click to trigger node Autocomplete
QilongTang
commented
May 25, 2021
| <!--Bind NodeAutoComplete to double left click--> | ||
| <Grid.InputBindings> | ||
| <MouseBinding MouseAction="LeftDoubleClick" Command="{Binding Path=NodeAutoCompleteCommand}"></MouseBinding> | ||
| </Grid.InputBindings> |
Contributor
Author
There was a problem hiding this comment.
Bind NodeAutoComplete to double left click here using Grid.InputBindings since Grid does not expose double left click event directly
reddyashish
approved these changes
May 25, 2021
Collaborator
reddyashish
left a comment
There was a problem hiding this comment.
Looks good to me. Do you think any unit tests need to be changed?
Contributor
Author
I will wait for the self serve to finish. I think the unit tests were using view command directly so we may be fine there but good points! |
Contributor
Author
|
All unit tests passing, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
As an alternative to #11709, use double left mouse click to trigger NodeAutoComplete instead of Alt + mouse left click. This end up being a cleaner implementation.
FYI: @Amoursol
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of