Skip to content

[DYN-3710] Enable Show CodeBlockNode Lines Number#11705

Merged
QilongTang merged 20 commits intoDynamoDS:masterfrom
Astul-Betizagasti:DYN-3710
May 25, 2021
Merged

[DYN-3710] Enable Show CodeBlockNode Lines Number#11705
QilongTang merged 20 commits intoDynamoDS:masterfrom
Astul-Betizagasti:DYN-3710

Conversation

@Astul-Betizagasti
Copy link
Contributor

@Astul-Betizagasti Astul-Betizagasti commented May 24, 2021

Purpose

Add and enable a toggle on the Preferences modal to turn CodeBlockNode Lines Number on and off
image

codeblocklines2

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

Aaron Tang (@QilongTang )

FYIs

Roberto Tellez (@RobertGlobant20 )

@mjkkirschner
Copy link
Member

@Astul-Betizagasti - if you check Dynamo 2.10 - when this setting is disabled, existing codeblocks should be modified, you should not need to recreate them to have the line numbers become visible or invisible.

@Astul-Betizagasti
Copy link
Contributor Author

@Astul-Betizagasti - if you check Dynamo 2.10 - when this setting is disabled, existing codeblocks should be modified, you should not need to recreate them to have the line numbers become visible or invisible.

I just added a commit to fix this issue and updated the gif on the description to reflect the right behavior

@Astul-Betizagasti
Copy link
Contributor Author

Astul-Betizagasti commented May 24, 2021

I found a regression regarding the Saved Changes label on the Preferences modal and included a fix on this PR.
Now that the PreferencesViewModel is being saved on DynamoViewModel, instead of creating a new one every time the modal opens, the Saved Changes label and its corresponding tooltip must be cleared every time the model is opened

@QilongTang QilongTang merged commit 32c777e into DynamoDS:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants