Users should be able to type into the Auto completion search window.#11701
Users should be able to type into the Auto completion search window.#11701reddyashish merged 3 commits intoDynamoDS:masterfrom
Conversation
…Prevent the window from hiding when the user clicks on the workspace.
mmisol
left a comment
There was a problem hiding this comment.
Hi @reddyashish . I think this is a good approach, however you might have to make some changes to the tests. If I remember correctly, in my original PR I had to change a test to make it close the window twice.
Also, does it work so that if you select a node, the dialog still closes automatically. That would be important for usability, not sure if you could add a test for it.
|
A couple of issues around the node autocompletion search are also fixed in this PR
|
Yes changed the test accordingly. Regarding the second question: when you select the node, the dialog closes automatically. I think we will need a UI automation test for that. |
|
Merging this. |


Purpose
Currently we have a regression on the master branch. The issue is that users are not able to type text into the Auto completion search window. After the new UI changes to the Autocompletion window, the window will not be closed/hidden when the user has clicked anywhere on the workspace as we now have a close button to close the window. We won't be needing the flag to monitor the behavior of the window.
Declarations
Check these if you believe they are true
*.resxfiles@QilongTang @zeusongit @mmisol