Skip to content

Users should be able to type into the Auto completion search window.#11701

Merged
reddyashish merged 3 commits intoDynamoDS:masterfrom
reddyashish:master
May 24, 2021
Merged

Users should be able to type into the Auto completion search window.#11701
reddyashish merged 3 commits intoDynamoDS:masterfrom
reddyashish:master

Conversation

@reddyashish
Copy link
Collaborator

@reddyashish reddyashish commented May 21, 2021

Purpose

Currently we have a regression on the master branch. The issue is that users are not able to type text into the Auto completion search window. After the new UI changes to the Autocompletion window, the window will not be closed/hidden when the user has clicked anywhere on the workspace as we now have a close button to close the window. We won't be needing the flag to monitor the behavior of the window.

NodeAutocompletion search box

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

@QilongTang @zeusongit @mmisol

…Prevent the window from hiding when the user clicks on the workspace.
Copy link
Collaborator

@mmisol mmisol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @reddyashish . I think this is a good approach, however you might have to make some changes to the tests. If I remember correctly, in my original PR I had to change a test to make it close the window twice.

Also, does it work so that if you select a node, the dialog still closes automatically. That would be important for usability, not sure if you could add a test for it.

@reddyashish
Copy link
Collaborator Author

reddyashish commented May 24, 2021

A couple of issues around the node autocompletion search are also fixed in this PR

  1. When the user enters some text in the search bar and clears it, the window should show the initial list of all the autocompletion elements for that port
  2. The tag dictionary that is being used in the Search API contains a list of all Dynamo nodes that share a specific tag. So when the SubsetDictionary was being built, if any one of the nodes from dictionary match the subset list, the whole list of nodes that share a specific tag was returned. This would generate extra results(which were not a match) when some particular text was entered in the search bar. To fix this, we match the subset list with the returned search results in the end. I will add a gif to show the difference in the results.

Before this PR:
NodeAutocompletion search before

After this PR:
NodeAutocompletion search after

@reddyashish
Copy link
Collaborator Author

reddyashish commented May 24, 2021

Hi @reddyashish . I think this is a good approach, however you might have to make some changes to the tests. If I remember correctly, in my original PR I had to change a test to make it close the window twice.

Also, does it work so that if you select a node, the dialog still closes automatically. That would be important for usability, not sure if you could add a test for it.

Yes changed the test accordingly. Regarding the second question: when you select the node, the dialog closes automatically. I think we will need a UI automation test for that.

@reddyashish
Copy link
Collaborator Author

Merging this.

@reddyashish reddyashish merged commit ea82bbe into DynamoDS:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants