Skip to content

Analytics Change for Preferences View#11696

Merged
QilongTang merged 2 commits intomasterfrom
PreferencesAnalytics
May 20, 2021
Merged

Analytics Change for Preferences View#11696
QilongTang merged 2 commits intomasterfrom
PreferencesAnalytics

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented May 19, 2021 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Analytics Change for Preferences View.

This PR covers analytics for the following area

  • Opening preferences panel
  • Closing preferences panel
  • Dragging preferences panel to move
  • Making switches in preferences panel

TODO: Should we track actions on expanders?

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

QilongTang
QilongTang commented May 19, 2021
View reviewed changes
src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs Outdated
Dynamo.Logging.Analytics.TrackEvent(
Actions.Switch,
Categories.Preferences,
Res.PreferencesViewLanguageLabel);
Copy link
Contributor Author

@QilongTang QilongTang May 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern introduce some repeated code but will be most accurate to avoid logging dialog initialization

QilongTang
QilongTang commented May 19, 2021
View reviewed changes
src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs Outdated
Dynamo.Logging.Analytics.TrackEvent(
Actions.Switch,
Categories.Preferences,
description);
Copy link
Contributor Author

@QilongTang QilongTang May 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way of logging is more code efficient.. But can't seem to rule out the cases for dialog initialization, because in those cases Dynamo raise property changes regardless if it's user change.. Will look a bit more on best way

Copy link
Contributor Author

@QilongTang QilongTang May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it back, since Model_PropertyChanged bind after dialog initialization, this approach should be accurate

@QilongTang QilongTang changed the title Analytics Change for Preferences View [WIP] Analytics Change for Preferences View May 19, 2021
QilongTang
QilongTang commented May 19, 2021
View reviewed changes
src/DynamoCoreWpf/Properties/Resources.resx
<value>Number Format</value>
<comment>Setting menu | Number format</comment>
</data>
<data name="DynamoViewSettingMenuRenderPrecision" xml:space="preserve">
Copy link
Contributor Author

@QilongTang QilongTang May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicate of PreferencesViewVisualSettingsRenderPrecision. @RobertGlobant20 @Astul-Betizagasti when you have time, let's review the resource strings we touched and make sure no duplicates were left.

@QilongTang QilongTang changed the title [WIP] Analytics Change for Preferences View Analytics Change for Preferences View May 19, 2021
@QilongTang QilongTang marked this pull request as ready for review May 19, 2021 16:57
zeusongit
zeusongit approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@zeusongit zeusongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang
Copy link
Contributor Author

QilongTang commented May 20, 2021

After some thoughts on expanders, seems tracking the clicking there provide minimum value to us. I feel it is reasonable to leave out as part of this PR because at least all working controls in preferences panel works already.

@QilongTang QilongTang merged commit fa2a9e9 into master May 20, 2021
@QilongTang QilongTang deleted the PreferencesAnalytics branch May 20, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeusongit zeusongit zeusongit approved these changes

@reddyashish reddyashish Awaiting requested review from reddyashish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QilongTang @zeusongit