Skip to content

[DYN-3684] Enable Show Edges and Isolate Selected Geometry#11694

Merged
QilongTang merged 15 commits intoDynamoDS:masterfrom
Astul-Betizagasti:master
May 19, 2021
Merged

[DYN-3684] Enable Show Edges and Isolate Selected Geometry#11694
QilongTang merged 15 commits intoDynamoDS:masterfrom
Astul-Betizagasti:master

Conversation

@Astul-Betizagasti
Copy link
Contributor

@Astul-Betizagasti Astul-Betizagasti commented May 19, 2021

Purpose

Enables the options Show Edges and Isolate Selected Geometry on the View Settings tab inside the Preferences modal.
edges+isolategeo

Align description under each Geometry Scaling option
1

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

Aaron Tang (@QilongTang )

FYIs

Roberto Tellez (@RobertGlobant20 )

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in the future we will need to move RenderPackageFactoryViewModel but for now it is good

@QilongTang QilongTang merged commit 02d82f6 into DynamoDS:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants