DYN-3606-Preferences Panel Expanders Functionality#11689
DYN-3606-Preferences Panel Expanders Functionality#11689QilongTang merged 13 commits intoDynamoDS:masterfrom RobertGlobant20:DYN-3606-Preferences-Expanders
Conversation
I added the functionality in the Features tab of having just one Expander expander at one time (this functionality already exits in the Visual Settings expander). Also I added the functionality of recording the current state of the Expander in a way that every time that the Preference window is closed and re-opened then the Expanders will remember the previous state. Due that this functionality was implemented by session then when the Dynamo app is closed the previous Expander settings will be lost.
Based in the comments done in the code review I removed the json entry created in the resources for loading the initial ExpanderSettings and now the list was initialized in the constructor.
Based in the code review comments instead of creating the PreferencesViewModel in PreferencesView.xaml.cs now will be created in DynamoViewModel.cs so the settings for expanders can be loaded/stored by session. Also the Expanders List was moved inside the PreferencesViewModel.
| new ExpanderSettings{ Name = "Styles", IsExpanded = false, Tab = "Visual Settings" }, | ||
| new ExpanderSettings{ Name = "Scale", IsExpanded = false, Tab = "Visual Settings" }, | ||
| new ExpanderSettings{ Name = "Precision", IsExpanded = false, Tab = "Visual Settings" }, | ||
| new ExpanderSettings{ Name = "Display", IsExpanded = false, Tab = "Visual Settings" }, |
There was a problem hiding this comment.
Do you think we can auto populate this list somehow?
There was a problem hiding this comment.
@QilongTang I cannot think of any way of auto populate this list but in order to avoid doing this I re-implemented the functionality of recording/loading the current expansion state of each expander in a List, now instead of recording each one only records the one expanded (only one Expander can be expanded per each tab), so the info for just one is loaded when the Preferences window is opened and just one info is saved when the Expander expansion state is updated (this approach was suggested by @Astul-Betizagasti ).
For implementing this functionality I added a Converter that will be binded in each Expander.IsExpanded as @mjkkirschner suggested.
This re-implementation allows to do the same functionality for Expanders with less code. Thanks
See commit:
RobertGlobant20@3924722
There was a problem hiding this comment.
Thank you @RobertGlobant20 @Astul-Betizagasti I am fine with the new approach as it reduces some complexity
Based on the code review comments: I changed the PreferencesViewModel property from public to Internal. I reorganized usings in the PreferencesViewModel.cs file. In the PreferencesView.xaml.cs due that I found a way to find all the Expanders in the PreferencesView, I refactored some code in a way and now there is no need to describe each expander name for binding the IsExpanded property.
I re-implemented the functionality of recording/loading the current expansion state of each expander in a List<ExpanderSettings>, now instead of recording each one only records the one expanded (only one Expander can be expanded per each tab), so the info for one is loaded when the Preferences window is opened and just one info is saved when the Expander expansion state is updated (thiis approach was suggested by Astul). For implementing this functionality I added a Converter that will be binded in each Expander as Michael suggested.
After fetching the latest changes in the master branch and merging the changes in my feature branch I got several conflicts, this fixes several errors.
The FindLogicalChildren method is not used then deleted and updating a typo in a comment
Removing no needed comment.
Fixed comment
| <Expander x:Name="PythonExpander" | ||
| Grid.Row="0" | ||
| Style="{StaticResource MenuExpanderStyle}" | ||
| IsExpanded="{Binding PreferencesTabs[0].ExpanderActive, Converter={StaticResource ExpandersBindingConverter}, ConverterParameter=PythonExpander}" |
There was a problem hiding this comment.
This design is a bit strange that if we will need to cover expander state for General tab in the future (which we know we will do soon :), we will need to shift the index here..
There was a problem hiding this comment.
@QilongTang I changed the data structure to use a Dictionary, so in the XAML we can use something more describing like "PreferencesTabs[Features]" also I added the General tab entry as an item in the Dictionary. Thanks
see commit: 4540d66
There was a problem hiding this comment.
@RobertGlobant20 Thanks, this looks way cleaner
Instead of using a list for binding the TabSettings Items in the PreferencesView.xaml , used a Dictionary so in the xaml file I can use something like PreferencesTabs[Features] for the bindings, also added the General tab as an item of the new dictionary.
3 participants
Purpose
I added the functionality in the Features tab of having just one Expander expander at one time (this functionality already exits in the Visual Settings expander).
Also I added the functionality of recording the current state of the Expander in a way that every time that the Preference window is closed and re-opened then the Expanders will remember the previous state. Due that this functionality was implemented by session then when the Dynamo app is closed the previous Expander settings will be lost.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@Astul-Betizagasti