Skip to content

update libg nugets#11678

Merged
aparajit-pratap merged 5 commits intoDynamoDS:masterfrom
aparajit-pratap:updateLibG
May 19, 2021
Merged

update libg nugets#11678
aparajit-pratap merged 5 commits intoDynamoDS:masterfrom
aparajit-pratap:updateLibG

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented May 11, 2021

Purpose

Update libg nugets. This includes:

  • Plane treated as infinite geometry for intersections and Point projection
  • New ASM journaling nodes only available in debug LibG builds
  • Fixes for regressions caused by Plane intersection improvements
  • Fix for T-Splines Pipe crash in ASM226

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good @aparajit-pratap - but lets wait for tests results before merging?

@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented May 11, 2021

it looks good @aparajit-pratap - but lets wait for tests results before merging?

There is a regression in one geometry workflow test due to the order of points resulting from plane-curve intersections 😢 . Investigating ...
Working on a fix ...

@aparajit-pratap aparajit-pratap merged commit 50b6544 into DynamoDS:master May 19, 2021
@aparajit-pratap aparajit-pratap deleted the updateLibG branch May 19, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants