Skip to content

Refactor for the Saved Changes label implementation#11676

Merged
QilongTang merged 66 commits intoDynamoDS:masterfrom
Astul-Betizagasti:addressing-pr-comments
May 11, 2021
Merged

Refactor for the Saved Changes label implementation#11676
QilongTang merged 66 commits intoDynamoDS:masterfrom
Astul-Betizagasti:addressing-pr-comments

Conversation

@Astul-Betizagasti
Copy link
Contributor

Purpose

Refactor the way the save changes label was implemented to avoid calling the update function multiple times. Also added a few request comments

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

Aaron Tang (@QilongTang )

Astul-Betizagasti and others added 30 commits July 6, 2020 17:48
Master update from public repo
Astul-Betizagasti and others added 25 commits February 3, 2021 10:27
Update master branch 4-3
update master branch 12/3
@Astul-Betizagasti Astul-Betizagasti requested review from QilongTang and RobertGlobant20 and removed request for RobertGlobant20 May 11, 2021 11:40
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang QilongTang merged commit e6a30ec into DynamoDS:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants