Dyn 3551 move save changes button#11567
Merged
QilongTang merged 17 commits intoDynamoDS:masterfrom Mar 24, 2021
RobertGlobant20:DYN-3551-Move-SaveChanges-Button
Merged
Dyn 3551 move save changes button#11567QilongTang merged 17 commits intoDynamoDS:masterfrom RobertGlobant20:DYN-3551-Move-SaveChanges-Button
QilongTang merged 17 commits intoDynamoDS:masterfrom
RobertGlobant20:DYN-3551-Move-SaveChanges-Button
Conversation
I added a new workflow (issue_type_predicte.yaml) that is using the ML.NET model for predicting the issue type (source repo), so If a new issue is created in the Dynamo repo this workflow will run and will predict if is a Wishlist issue or not. If is a Wishlist issue it will be labeled as "Wishlist" and then another workflow will move the issue to the DynamoWishlist repo. If the issue is incomplete or is not valid the label "NotMLEvaluated" will be added to the issue. Also I added two scripts more, one will return the issue body in a json string and the other one will clan the issue body removing sections not used like "Dynamo Version" or "Stack Trace"
When testing the issue predicter workflow the issues labeled as Wishlist were not moved to the DynamoWishlist repo due that the "Move Issue by labels" workflow failed. There was a problem with the PAT used to label the issue, I was using the wrong one (no triggers actions).
Due that the previous PR related to creating the Preference panel was approved and merged a new Jira task (also a branch - PR) was created for moving the Save Changes button further to the right. Then I modified the margin of the Save Changes button to be aligned with the Close button at the top.
Contributor
Author
|
Here is a gif of how the window looks like. |
QilongTang
approved these changes
Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Due that the previous PR related to creating the Preference panel was approved and merged a new Jira task (also a branch - PR) was created for moving the Save Changes button further to the right. Then I modified the margin of the Save Changes button to be aligned with the Close button at the top.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@Amoursol