Document experience marking node libraries when publishing a package in Documentation browser#11539
Merged
zeusongit merged 10 commits intoDynamoDS:masterfrom Mar 19, 2021
Merged
Document experience marking node libraries when publishing a package in Documentation browser#11539zeusongit merged 10 commits intoDynamoDS:masterfrom
zeusongit merged 10 commits intoDynamoDS:masterfrom
Conversation
Member
|
this looks really nice! |
Amoursol
reviewed
Mar 17, 2021
Contributor
Amoursol
left a comment
Amoursol
left a comment
There was a problem hiding this comment.
Comments in-line @zeusongit ! :)
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you @Amoursol for the review, I have made the changes as requested. |
QilongTang
reviewed
Mar 17, 2021
QilongTang
approved these changes
Mar 17, 2021
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Other than one comment, looks solid
Contributor
|
Does this documentation describe how package authors can add package dependencies like @LongNguyenP was requesting for DynaShape? |
Contributor
No, plus Long is using a work around. I would be hesitate to add that until we support it on the publish UI. The documentation here is meant to cover all operations user can do on the publish dialog |
QilongTang
approved these changes
Mar 18, 2021
zeusongit
added a commit
to zeusongit/Dynamo
that referenced
this pull request
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Added documentation related to publishing a package to Package manager inside dynamo.
Can be triggered clicking an icon on the publish package dialog box.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo