WIP use product code to lookup product install when displayName returns null#11479
Merged
mjkkirschner merged 3 commits intoDynamoDS:masterfrom Feb 11, 2021
Merged
WIP use product code to lookup product install when displayName returns null#11479mjkkirschner merged 3 commits intoDynamoDS:masterfrom
mjkkirschner merged 3 commits intoDynamoDS:masterfrom
Conversation
mjkkirschner
changed the title
pinzart90
approved these changes
Feb 8, 2021
Contributor
pinzart90
left a comment
pinzart90
left a comment
There was a problem hiding this comment.
LGTM
Unit test for this case?
add friend assembly for moq add test fix broken tests add fallback for interface
Member
Author
|
@pinzart90 please take another look - I think I've added a sufficient test and fixed the other tests that this broke (their mocks needed the new method added) I also added a fallback if someone passes an interface type to this method. |
pinzart90
approved these changes
Feb 9, 2021
Member
Author
|
@pinzart90 I think i'd like to wait on merging this until the build is back up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
I found that even though we started cacheing the product keys during asm product lookup - we were not actually using them to look in the registry to find the matching product - we were only using display name.
certain products no longer use their display name, and instead use their product code.
The following PR first tries to lookup the product in the cached registry data using the product name, then it uses the product key if the former returns null.
After this PR DynamoSandbox on my machine finds Revit 2022 and Revit 2021 as products with asm.
Declarations
Check these if you believe they are true
*.resxfiles