Change If node behaviour to avoid replication over true and false scopes#11464
Closed
aparajit-pratap wants to merge 2 commits intoDynamoDS:masterfrom
Closed
Change If node behaviour to avoid replication over true and false scopes#11464aparajit-pratap wants to merge 2 commits intoDynamoDS:masterfrom
aparajit-pratap wants to merge 2 commits intoDynamoDS:masterfrom
Conversation
8 tasks
Collaborator
|
Due to some authentication issue, I couldn't push my changes to this remote branch. So created a new one and closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-1976
Proposed a solution where the following DS code is translated as AST output for the
IfNodeModel node:These changes cause the node to behave as per common user expectation as well as match the
ScopeIf+clockwork package node behaviour.This translates to building a conditional expression, an array, and an indexing expression in the AST for the NodeModel node.
Lacing and partial function support do not seem to make much sense for this new
Ifnode and have been omitted.WIP for @reddyashish :
Declarations
Check these if you believe they are true
*.resxfilesFYIs
@reddyashish