Cherry picks for RC2.10.1#11436
Merged
QilongTang merged 6 commits intoRC2.10.1_masterfrom Jan 28, 2021
Merged
Conversation
…#11394) * Initial Commit with settings null check * Add unit test * Add view extension loading warning * Update message
* Do not aggregate node execution analytics anymore * Update to use new event combo * Update Comments
There were two classes that were declaring an 'AlsoKnownAs' attribute for 'DSCoreNodesUI.Input.IntegerSlider' in 'CoreNodeModels.Input': 'IntegerSlider' and 'IntegerSlider64Bit'. While the latter obsoletes the former, it is not possible to migrate to it from XML, so only 'IntegerSlider' should continue declaring an 'AlsoKnownAs' attribute. Note that currently both classes are trying to be registered, which results in only one of them being registered but not really making any guarantees of which one it is. This also generates an exception catched internally but shown in the console.
This is done to provide meaningful output when a dictionary is provided to nodes like 'String from Array' and 'String from Object'. These nodes call built-in DS functions that end up calling ToString on the dictionary, which until now used the default implementation inherited from Object which just returned the class name.
QilongTang
requested review from
mjkkirschner,
mmisol,
reddyashish and
zeusongit
zeusongit
approved these changes
Jan 28, 2021
Contributor
Author
|
Merging to finalize RC2.10.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Cherrypicking the following fixes into RC2.10.1:
(#11358) for dictionary data to display correctly
(#11360) to avoid an exception thrown in console about int64 slider
(#11356) to no longer aggregate node execution in analytics
(#11366) for adding package loading analytics
(#11394) to avoid a crash when view extension is returning random GUIDs
(#11361) for correction of icons of nodes added in Dynamo 2.10.0
The above list are fixes with low risk and affect stability and analytics in Dynamo. Please check.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of