Node Annotation Update: CoreNodeModels MapCombineLacing DesignScriptBuiltIn.Dictionary#11424
Merged
mmisol merged 4 commits intoDynamoDS:masterfrom Jan 29, 2021
Conversation
mmisol
reviewed
Jan 28, 2021
Collaborator
mmisol
left a comment
There was a problem hiding this comment.
@martinstacey Added some minor comments. Please take a look. Thanks!
Contributor
Author
Thanks @mmisol! will have a look at the comments. |
mmisol
approved these changes
Jan 29, 2021
Collaborator
mmisol
left a comment
There was a problem hiding this comment.
Thanks for addressing the changes @martinstacey . Looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The following PR addresses nodes' names and descriptions to make them more descriptive for beginners, PRs are organized according to location in DynamoDS.
These corrections are for CoreNodeModels.MapCombineLacing and DesignScriptBuiltIn.Dictionary
NODE 177 : ReplaceByCondition
Description Input: Predicate used to determine if it should be replaced -> Replacement function used to determine if an object should be replaced
Description Output: If condition(item) = True, then replaceWith is returend. Otherwise item is returned unaltered -> Item, or list with items replaced by condition
NODE 183 : List.Filter
Description Input: Predicate used to determine if an element is filtered in or out. -> Filter function used to determine if an element is filtered in our out
NODE 129 : Dictionary.Components
Description Output: The keys of the dictionary -> Keys of the dictionary
Description Output: The values of the dictionary -> Values of the dictionary
NODE 344 : Dictionary.Values
Description Output: The values of the Dictionary. -> Values of the dictionary
NODE 345 : Dictionary.Keys
Description Output: The keys of the Dictionary -> Keys of the dictionary
NODE 346 : Dictionary.ValueAtKey
Description Input: The key in the Dictionary to obtain. -> The key in the dictionary to obtain value
Description Output: The value at the specified key or null if it is not set. -> Value at the specified key or null if it is not set
NODE 347 : Dictionary.SetValueAtKeys
Description Output: A new Dictionary with the entries inserted -> New dictionary with the entries inserted
NODE 530 : Dictionary.Count
Description Output: int -> Number of key value pairs in dictionary
NODE 531 : Dictionary.RemoveKeys
Description Input: The key in the Dictionary to remove -> Keys to remove
Description Output: A new Dictionary with the key removed -> New dictionary with keys removed
NODE 532 : Dictionary.ByKeysValues
Description Input: The string keys of the Dictionary -> Keys of dictionary
Description Input: The values of the Dictionary -> Values of dictionary
Description Output: The result Dictionary -> Dictionary from keys and values
FYI
For nodes Dictionary.Components, Dictionary.Values, Dictionary.Keys, Dictionary.ValueAtKey, Dictionary.SetValueAtKeys, Dictionary.Count, Dictionary.RemoveKeys, Dictionary.ByKeysValues These nodes are using a property of class Dictionary, so I do not know how to change the description for input location. I would make these changes to the inputs descriptions:
Description Input: DesignScript.Builtin.Dictionary -> Dictionary to extract components from
Description Input: DesignScript.Builtin.Dictionary -> Dictionary to query values from
Description Input: DesignScript.Builtin.Dictionary -> Dictionary to query value at key from
Description Input: DesignScript.Builtin.Dictionary -> Dictionary to set value at key
Description Input: DesignScript.Builtin.Dictionary -> Dictionary to query keys from
Description Input: DesignScript.Builtin.Dictionary -> Dictionary to count number of key value pairs from
Description Input: DesignScript.Builtin.Dictionary -> Dictionary to remove keys from
Reviewers
@Amoursol @aparajit-pratap @QilongTang