Merged
Conversation
Member
|
LGTM |
| <package id="DynamoVisualProgramming.LibG_225_0_0" version="2.9.0.3356" targetFramework="net48" developmentDependency="true" /> | ||
| <package id="DynamoVisualProgramming.LibG_226_0_0" version="2.9.0.3355" targetFramework="net48" developmentDependency="true" /> | ||
| <package id="DynamoVisualProgramming.LibG_227_0_0" version="2.9.0.3355" targetFramework="net48" developmentDependency="true" /> | ||
| <package id="DynamoVisualProgramming.LibG_226_0_0" version="2.9.0.3865" targetFramework="net48" developmentDependency="true" /> |
Member
There was a problem hiding this comment.
@aparajit-pratap one question about this change - does this actually remove libG_225 from the bin folder? We just need to consider two things when doing this:
- should we also remove 225 from the supported version lists at the same time.
- Does this effect patch installers - has anyone included multiple libG folders in their patch installers? Should we just keep 225 around even if we dont support it, just in case.
Contributor
Author
There was a problem hiding this comment.
It might result in removing the libg_225 folder with a fresh build of Dynamo, I'll need to test to make sure. For the time being, I can leave libg_225 around with the last NuGet package version we have for it. I can file a task to actually remove it later (including supported versions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Update libg nugets.
Change log:
Declarations
Check these if you believe they are true
*.resxfilesFYIs
@QilongTang