Node Annotation Update: CoreNodeModels.Watch, CoreNodes.Color#11406
Merged
zeusongit merged 2 commits intoDynamoDS:masterfrom Jan 28, 2021
Merged
Node Annotation Update: CoreNodeModels.Watch, CoreNodes.Color#11406zeusongit merged 2 commits intoDynamoDS:masterfrom
zeusongit merged 2 commits intoDynamoDS:masterfrom
Conversation
Watch Node Description, Input description and output description updated
Contributor
|
LGTM @martinstacey |
zeusongit
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The following PR addresses nodes' names and descriptions to make them more descriptive for beginners, PRs are organized according to location in DynamoDS.
These corrections are for CoreNodeModels.Watch and CoreNodes.Color
NODE 127 : Watch
Description: Visualize the output of node. -> Visualize the node's output
Description Input: Node to evaluate -> Node to show output from
Description Output: Watch content -> Node output
NODE 340 : Color.Brightness
Input: c -> color
Description Input: Color -> Color to query brightness from
Output: brightness -> double
Description Output: double between 0 and 1 inclusive. -> Brightness value (between 0 and 1 inclusive)
NODE 341 : Color.Multiply
Input: c1 -> color
Description Input: Color -> Color to multiply
Input: div -> multiplier
Description Input: double -> Multiplier value
Output: Color -> color
Description Output: Color -> Color result from multiplication
NODE 342 : Color.Divide
Input: c1 -> color
Description Input: Color -> Color to divide
Input: div -> dividend
Description Input: double -> Dividend value
Output: Color -> color
Description Output: Color -> Color result from division
NODE 343 : Color.ByARGB
Input: a -> alpha
Description Input: The alpha value. -> Alpha value, int between 0 and 255 inclusive.
Input: r -> red
Description Input: The red value -> Red value for RGB color model, int between 0 and 255 inclusive.
Input: g -> green
Description Input: The green value. -> Green value for RGB color model, int between 0 and 255 inclusive.
Input: b -> blue
Description Input: The blue value. -> Blue value for RGB color model, int between 0 and 255 inclusive.
Description Output: Color -> Color created from ARGB
NODE 529 : Color.Add
Description: Construct a Color by combining two input Colors. -> Construct a color by combining the ARGB values of two existing colors.
Input: c1 -> color
Description Input: Color -> Color to add
Input: c2 -> otherColor
Description Input: Color -> Other color to add
Reviewers
@Amoursol @aparajit-pratap @QilongTang