Node Annotation Update: CoreNodeModels.FileSystem.Directory , CoreNodeModels.FileSystem.FileName , and CoreNodeModels.Formula #11390
Merged
zeusongit merged 3 commits intoDynamoDS:masterfrom Jan 21, 2021
Conversation
Contributor
|
Non-code review looks good to me @martinstacey ! |
File path node description updated, and resource reference corrected
zeusongit
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The following PR addresses nodes' names and descriptions to make them more descriptive for beginners, PRs are organized according to their location in DynamoDS.
This corrections are for CoreNodeModels.FileSystem.Directory , CoreNodeModels.FileSystem.FileName , and CoreNodeModels.Formula
NODE 238 : File Path
Description Output: Filename -> File Path
NODE 239 : Directory Path
Description Output: Directory -> Directory path
NODE 356 : Formula
Description Output: Result of math computation -> Result from formula
Reviewers
@Amoursol @aparajit-pratap @QilongTang