Skip to content

[DYN-3342] Close stale issues#11387

Merged
QilongTang merged 39 commits intoDynamoDS:masterfrom
Astul-Betizagasti:close-stale-issues
Jan 8, 2021
Merged

[DYN-3342] Close stale issues#11387
QilongTang merged 39 commits intoDynamoDS:masterfrom
Astul-Betizagasti:close-stale-issues

Conversation

@Astul-Betizagasti
Copy link
Contributor

Purpose

Add a new workflow that will close issues that have been stale for 30 days or more and have the "need more info" label.
This workflow uses the Stale action that is maintained by GitHub.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

Aaron Tang (@QilongTang )

FYIs

Alfredo Pozo (@alfredo-pozo )

Astul-Betizagasti and others added 30 commits July 6, 2020 17:48
Master update from public repo
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
#This message is requiered but never used.
stale-issue-message: "."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean?

Copy link
Contributor Author

@Astul-Betizagasti Astul-Betizagasti Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default the action will leave a message when marking the issue as stale and another-one when closing the issue. As we only want the message to be added when the issue is closed, the "skip-stale-issue-message" parameter was set to true but the action wont work if the "stale-issue-message" doesn't have a value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Astul-Betizagasti does empty string works in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang QilongTang merged commit 8ac994c into DynamoDS:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants