Skip to content

Node Annotation Update CoreNodes.Object and CoreNodes.String#11371

Merged
QilongTang merged 4 commits intoDynamoDS:masterfrom
martinstacey:CoreNodes-Object-InternalReview
Jan 22, 2021
Merged

Node Annotation Update CoreNodes.Object and CoreNodes.String#11371
QilongTang merged 4 commits intoDynamoDS:masterfrom
martinstacey:CoreNodes-Object-InternalReview

Conversation

@martinstacey
Copy link
Contributor

Purpose
The following PR addresses nodes' names and descriptions to make them more descriptive for beginners, PRs are organized according to the location in DynamoDS.

These corrections are for CoreNodes.Object and CoreNodes.String

NODE 220 : Object.Type
Input: obj -> object
Description Input: An object. -> Object to query type

NODE 130 : String.ToNumber
Input: str -> string

NODE 131 : String.Substring
Input: str -> string
Output: substring -> string

NODE 132 : String.Split
Input: str -> string

NODE 133 : String.PadRight
Input: str -> string
Input: newWidth -> newLength
Output: str -> string

NODE 134 : String.PadLeft
Input: str -> string
Input: newWidth -> newLength
Output: str -> string

NODE 135 : String.ChangeCase
Input: str -> string
Output: str -> string

NODE 136 : String.Center
Description: Increases the width of a string by encasing the original characters with spaces on either side. -> Increases the length of a string by encasing the original characters with spaces on either side.
Input: str -> string
Input: newWidth -> newLength
Description Input: Total length of the string after centering. -> Total length of the string after centering
Output: str -> string

NODE 137 : String.CountOccurrences
Input: str -> string
Output: count -> int

NODE 138 : String.Contains
Input: str -> string

NODE 533 : String.Length
Input: str -> string
Output: length -> int

NODE 535 : String.IndexOf
Input: str -> string
Description Input: A string to search in. -> String to search in
Output: index -> int

image

Reviewers

@Amoursol
@aparajit-pratap
@QilongTang

@Amoursol
Copy link
Contributor

LGTM @martinstacey

@QilongTang QilongTang merged commit b273395 into DynamoDS:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants