Node Annotation Update CoreNodes.List#11370
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Jan 25, 2021
Merged
Conversation
Contributor
|
LGTM @martinstacey |
QilongTang
approved these changes
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The following PR addresses nodes' names and descriptions to make them more descriptive for beginners, PRs are organized according to the location in DynamoDS.
These corrections are for CoreNodes.List
NODE 165 : List.Transpose
Description Input: A list of lists to be transposed -> List of lists to be transposed
Description Output: A list of transposed lists. -> List of transposed lists.
NODE 166 : List.SortIndexByValue
Description Input: The list of items to be sorted -> List of items to be sorted
Output: newList -> int[]
Description Output: The indices of the items in the sorted list. -> Indices of the items in the sorted list.
NODE 167 : List.Sort
Output: newList -> list
Description Output: The indices of the items in the sorted list. -> Sorted list
NODE 171 : List.Reorder
Description Output: The reordered list. -> Reordered list.
NODE 172 : List.GroupByKey
Output: unique keys -> uniqueKeys
NODE 177 : ReplaceByCondition
Description Input: Predicate used to determine if it should be replaced -> Replacement function used to determine if an object should be replaced
Output: var -> item
Description Output: If condition(item) = True, then replaceWith is returend. Otherwise item is returned unaltered -> Item replaced by condition
NODE 180 : List.Insert
Description Output: The list with the element inserted -> List with the element inserted
NODE 181 : List.Flatten
Input: amt -> amount
Description Input: Layers of nesting to remove. -> Layers of list nesting to remove (-1 will remove all list nestings)
Output: var[]..[] -> list
Description Output: var[]..[] -> Flattened list by amount
NODE 187 : List.AddItemToFront
Description Output: New list. -> List with added items
NODE 188 : List.AddItemToEnd
Output: var[]..[] -> list
Description Output: var[]..[] -> List with added items
NODE 192 : List.SetUnion
Output: newList -> list
NODE 193 : List.SetIntersection
Output: newList -> list
NODE 194 : List.SetDifference
Output: newList -> list
NODE 195 : List.MinimumItem
Description Input: List to take the minimum value from -> List of comparable items to take the minimum value from
Output: min -> item
Description Output: Minimum value from the list. -> Minimum item from the list.
NODE 196 : List.MaximumItem
Description Input: List to take the maximum value from -> List of comparable items to take the maximum value from
Output: max -> item
Description Output: Maximum value from the list. -> Maximum item from the list.
NODE 197 : List.LastItem
Output: last -> item
NODE 201 : List.IsEmpty
Description Input: List to check for items, -> List to be checked if it is empty
Description Output: Whether the list is empty. -> True if list is empty, false if it isn't
NODE 207 : List.Contains
Description Output: Whether list contains the given item. -> True if list contains item, false if it doesn’t
NODE 208 : List.AllTrue
Description Output: Whether all items are true. -> True if all items from list are true, false if one or more items is not true
NODE 209 : List.AllIndicesOf
Output: var[]..[] -> indices
NODE 210 : List.AllFalse
Description Output: Whether all items are false. -> True if all items from list are false, false if one or more items is not false
NODE 213 : List.Combinations
Output: comb -> lists
NODE 359 : List.Clean
Description Input: var[]..[] -> List containing nulls and empty sublists to clean
Output: var[]..[] -> list
Reviewers
@Amoursol
@QilongTang
@aparajit-pratap