Node Annotation Update CoreNodes.Math#11369
Merged
QilongTang merged 7 commits intoDynamoDS:masterfrom Jan 25, 2021
Merged
Conversation
Math.Xor, Math.Tanh, Math.Tan, Math.Sum, Math.Sign(int), Math.Sign(number), Math.Round(number,digits), Math.Round(number), Math.Floor, Math.Factorial, Math.Ceiling, Math.Average, Math.Abs, Math.Map
Nodes changed 658-661
This reverts commit 0f6c83b.
Contributor
|
@martinstacey - Please add 'Down' to description as below: NODE 160 : Math.Floor |
Added the word ‘down’ to differentiate with Math Ceiling
Contributor
Author
Addressed in c48acff |
QilongTang
approved these changes
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The following PR addresses nodes' names and descriptions to make them more descriptive for beginners, PRs are organized according to the location in DynamoDS.
These nodes are located on CoreNodes.Math
NODE 152: Math.Xor
Input: a -> bool
Description Input: a boolean -> A boolean
Input: b -> otherBool
Description Input: a boolean -> Other boolean
NODE 153: Math.Tanh
Description Input: an angle in radians -> Angle in radians
Output: tanh -> double
NODE 154: Math.Tan
Description Input: An angle in radians -> Angle in radians
Output: tan -> double
NODE 155: Math.Sum
Description Input: The numbers to sum -> Numbers to add to sum
Output: sum -> double
NODE 156 : Math.Sign(int)
Description: Returns the sign of the number: -1, 0 ir 1 -> Returns the sign of the number: -1, 0 or 1
Input: integer -> int
Description Input: int -> Integer to get sign from
Output: sign -> int
NODE 157 : Math.Sign(number)
Description: Returns the sign of the number: -1, 0 ir 1 -> Returns the sign of the number: -1, 0 or 1
Description Input: A number. -> Number to get sign from
Output: sign -> int
NODE 158 : Math.Round(number,digits)
Description Input: A number to be rounded -> Number to round
NODE 160 : Math.Floor
Description Input: Number to round up. -> Number to round
Output: integer -> int
NODE 162 : Math.Ceiling
Output: integer -> int
NODE 163 : Math.Average
Output: average -> double
NODE 164 : Math.Abs
Description Input: A number. -> Number to get absolute value from
Output: absoluteValue -> number
NODE 658 : Math.PiTimes2
Description: Pi Constant Multiplied by 2 -> Pi constant multiplied by 2
Output: 2pi -> double
NODE 659 : Math.PI
Output: pi -> double
Description Output: double. The constant Pi. -> The constant Pi.
NODE 660 : Math.GoldenRatio
Output: phi -> double
Description Output: double. The golden ratio. -> The golden ratio.
NODE 661 : Math.E
Output: e -> double
Description Output: double. The constant e. -> The constant e.
Reviewers
@Amoursol
@aparajit-pratap
@QilongTang