Skip to content

Node Annotation Update CoreNodes.Math#11369

Merged
QilongTang merged 7 commits intoDynamoDS:masterfrom
martinstacey:CoresNodes-Math-140-141_152-164
Jan 25, 2021
Merged

Node Annotation Update CoreNodes.Math#11369
QilongTang merged 7 commits intoDynamoDS:masterfrom
martinstacey:CoresNodes-Math-140-141_152-164

Conversation

@martinstacey
Copy link
Contributor

Purpose
The following PR addresses nodes' names and descriptions to make them more descriptive for beginners, PRs are organized according to the location in DynamoDS.
These nodes are located on CoreNodes.Math

NODE 152: Math.Xor
Input: a -> bool
Description Input: a boolean -> A boolean
Input: b -> otherBool
Description Input: a boolean -> Other boolean

NODE 153: Math.Tanh
Description Input: an angle in radians -> Angle in radians
Output: tanh -> double

NODE 154: Math.Tan
Description Input: An angle in radians -> Angle in radians
Output: tan -> double

NODE 155: Math.Sum
Description Input: The numbers to sum -> Numbers to add to sum
Output: sum -> double

NODE 156 : Math.Sign(int)
Description: Returns the sign of the number: -1, 0 ir 1 -> Returns the sign of the number: -1, 0 or 1
Input: integer -> int
Description Input: int -> Integer to get sign from
Output: sign -> int

NODE 157 : Math.Sign(number)
Description: Returns the sign of the number: -1, 0 ir 1 -> Returns the sign of the number: -1, 0 or 1
Description Input: A number. -> Number to get sign from
Output: sign -> int

NODE 158 : Math.Round(number,digits)
Description Input: A number to be rounded -> Number to round

NODE 160 : Math.Floor
Description Input: Number to round up. -> Number to round
Output: integer -> int

NODE 162 : Math.Ceiling
Output: integer -> int

NODE 163 : Math.Average
Output: average -> double

NODE 164 : Math.Abs
Description Input: A number. -> Number to get absolute value from
Output: absoluteValue -> number
NODE 658 : Math.PiTimes2
Description: Pi Constant Multiplied by 2 -> Pi constant multiplied by 2
Output: 2pi -> double

NODE 659 : Math.PI
Output: pi -> double
Description Output: double. The constant Pi. -> The constant Pi.

NODE 660 : Math.GoldenRatio
Output: phi -> double
Description Output: double. The golden ratio. -> The golden ratio.

NODE 661 : Math.E
Output: e -> double
Description Output: double. The constant e. -> The constant e.

image

Reviewers

@Amoursol
@aparajit-pratap
@QilongTang

Math.Xor, Math.Tanh, Math.Tan, Math.Sum, Math.Sign(int), Math.Sign(number), Math.Round(number,digits), Math.Round(number), Math.Floor, Math.Factorial, Math.Ceiling, Math.Average, Math.Abs, Math.Map
Nodes changed 658-661
@martinstacey martinstacey changed the title Nodes-Annotations-Cores-nodes-Math Node Annotation Update CoreNodes.Math Dec 18, 2020
@Amoursol
Copy link
Contributor

@martinstacey - Please add 'Down' to description as below:

NODE 160 : Math.Floor
Description Input: Number to round up. -> Number to round down
Output: integer -> int

Added the word ‘down’ to differentiate with Math Ceiling
@martinstacey
Copy link
Contributor Author

@martinstacey - Please add 'Down' to description as below:

NODE 160 : Math.Floor
Description Input: Number to round up. -> Number to round down
Output: integer -> int

Addressed in c48acff

@QilongTang QilongTang merged commit a24bc25 into DynamoDS:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants