Do not aggregate node execution analytics anymore#11355
Closed
dynamo-ci-user wants to merge 1 commit intomasterfrom
Closed
Do not aggregate node execution analytics anymore#11355dynamo-ci-user wants to merge 1 commit intomasterfrom
dynamo-ci-user wants to merge 1 commit intomasterfrom
Conversation
mmisol
reviewed
Dec 10, 2020
| Categories.Performance, | ||
| e.Task.GetType().Name, | ||
| executionTimeSpan, node.GetOriginalName()); | ||
| } |
Collaborator
There was a problem hiding this comment.
This doesn't seem like a good indicator of performance. How about only tracking when there is only 1 node being modified instead? That way we get less events but at least the info we get is closer to reality.
Collaborator
|
Unrelated, but I was surprised this PR was opened by |
Contributor
Oh man this is my bad I will re create this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Previously, node execution analytics data was aggregated with comma, e.g.
This makes data less straight forward to parse on backend with all kinds of combos of modified nodes during execution.
After this PR, each executed node will be tracked individually.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of