CP: DYN-2381 Exclude code block nodes from SetArgumentLacing (#11294)#11327
Merged
QilongTang merged 1 commit intoRC2.10.0_masterfrom Dec 4, 2020
Merged
CP: DYN-2381 Exclude code block nodes from SetArgumentLacing (#11294)#11327QilongTang merged 1 commit intoRC2.10.0_masterfrom
QilongTang merged 1 commit intoRC2.10.0_masterfrom
Conversation
* Exclude code block nodes from SetArgumentLacing * Added test to check code block lacing doesn't change * Restructured code block lacing test * Exclude all LacingStrategy.Disabled nodes from SetArgumentLacing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude code block nodes from SetArgumentLacing
Added test to check code block lacing doesn't change
Restructured code block lacing test
Exclude all LacingStrategy.Disabled nodes from SetArgumentLacing
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
CP: DYN-2381 Exclude code block nodes from SetArgumentLacing (#11294)
Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
@DynamoDS/dynamo