CP: DYN-1078 Prevent - Button Removing Required Ports #11288#11324
Merged
QilongTang merged 1 commit intoRC2.10.0_masterfrom Dec 4, 2020
Merged
CP: DYN-1078 Prevent - Button Removing Required Ports #11288#11324QilongTang merged 1 commit intoRC2.10.0_masterfrom
- Button Removing Required Ports #11288#11324QilongTang merged 1 commit intoRC2.10.0_masterfrom
Conversation
* Only remove inputs when count is greater than defaultNumInputs * Only remove inputs when count is greater than defaultNumInputs * Added test to ensure default ports can't be removed * Don't remove default inputs for DSVarArgFunction nodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
CP: DYN-1078 Prevent
-Button Removing Required Ports #11288Declarations
Check these if you believe they are true
*.resxfilesReviewers
FYIs
@DynamoDS/dynamo