DYN-2381 Exclude code block nodes from SetArgumentLacing#11294
DYN-2381 Exclude code block nodes from SetArgumentLacing#11294QilongTang merged 4 commits intoDynamoDS:masterfrom
Conversation
mmisol
left a comment
mmisol
left a comment
There was a problem hiding this comment.
While this PR does what it was asked for, this is not only a problem with Code Block nodes. Python Script nodes suffer the same issue and probably others do.
By taking a look at the code, I could see NodeModel has a property named ArgumentLacing that should be set to LacingStrategy.Disabled when lacing is not supported by the node. Using that, rather than excluding by type like in https://github.com/DynamoDS/Dynamo/pull/11294/files#diff-14fa24535a2d0aa34f993496cc35eb02dbadcffb7576a54cbeef2e9821edba8cR1131, should be the right way to solve this IMO.
|
* Exclude code block nodes from SetArgumentLacing * Added test to check code block lacing doesn't change * Restructured code block lacing test * Exclude all LacingStrategy.Disabled nodes from SetArgumentLacing
…1327) * Exclude code block nodes from SetArgumentLacing * Added test to check code block lacing doesn't change * Restructured code block lacing test * Exclude all LacingStrategy.Disabled nodes from SetArgumentLacing Co-authored-by: Laurence Elsdon <[email protected]>
3 participants
Purpose
JIRA: DYN-2381
Exclude Code Block Nodes when setting the lacing by selecting multiple nodes and right clicking on the canvas.
The previous behaviour did nothing but causes some visual anomalies and can be confusing to a user.
Previous Behaviour:
Revised Behaviour
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @QilongTang @mmisol
FYIs
@Amoursol