DYN-1078 Prevent - Button Removing Required Ports#11288
DYN-1078 Prevent - Button Removing Required Ports#11288QilongTang merged 4 commits intoDynamoDS:masterfrom
- Button Removing Required Ports#11288Conversation
|
@StudioLE - thanks for the fix- can you also try adding a test that calls the |
|
@StudioLE - unfortunately there are 4 failing tests now: @SHKnudsen should have access to this dashboard if you do not - can you try these out locally? |
|
Thanks @mjkkirschner, we'll have a look. |
|
Thanks @mjkkirschner. This is now resolved with 70f0e24.
|
| model.InPorts.Remove(port); | ||
| } | ||
|
|
||
| MarkNodeDirty(); |
There was a problem hiding this comment.
@StudioLE @mjkkirschner One thing I found from my local testing of this is that, even with the default state and user would not delete default ports, but node still marked dirty which I think is not necessary because that will trigger a graph run. Can we make another PR and put the statement in the if above?
* Only remove inputs when count is greater than defaultNumInputs * Only remove inputs when count is greater than defaultNumInputs * Added test to ensure default ports can't be removed * Don't remove default inputs for DSVarArgFunction nodes
* Only remove inputs when count is greater than defaultNumInputs * Only remove inputs when count is greater than defaultNumInputs * Added test to ensure default ports can't be removed * Don't remove default inputs for DSVarArgFunction nodes Co-authored-by: Laurence Elsdon <[email protected]>
4 participants
Purpose
JIRA: DYN-1078
Issue: #8741
Prevent the user from being able to remove default ports using the
-button onDSVarArgFunctionnodesBehaviour before:
Behaviour after:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @ QilongTang @mmisol
FYIs
@Amoursol